linux-kernel - Re: [PATCH][v12] PM / hibernate: Verify the consistent of e820 memory map by md5 digest

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 24 Oct 2016 15:07:24 +0200
From:   "Rafael J. Wysocki" <rafael@...nel.org>
To:     Pavel Machek <pavel@....cz>
Cc:     joeyli <jlee@...e.com>, Chen Yu <yu.c.chen@...el.com>,
        Linux PM <linux-pm@...r.kernel.org>,
        "the arch/x86 maintainers" <x86@...nel.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        "H. Peter Anvin" <hpa@...or.com>, Ingo Molnar <mingo@...hat.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        "Rafael J . Wysocki" <rafael.j.wysocki@...el.com>,
        Borislav Petkov <bp@...en8.de>,
        Len Brown <len.brown@...el.com>,
        Denys Vlasenko <dvlasenk@...hat.com>,
        Dan Williams <dan.j.williams@...el.com>
Subject: Re: [PATCH][v12] PM / hibernate: Verify the consistent of e820 memory
 map by md5 digest

On Sun, Oct 23, 2016 at 10:01 AM, Pavel Machek <pavel@....cz> wrote:
> Hi!
>
>> > 2. Another case is, this patch replies on comparing the e820_saved, but
>> >    currently the e820_save might not be strictly the same across
>> >    hibernation, even if BIOS has provided consistent e820 map - In
>> >    theory mptable might modify the BIOS-provided e820_saved dynamically
>> >    in early_reserve_e820_mpc_new, which would allocate a buffer from
>> >    E820_RAM, and marks it from E820_RAM to E820_RESERVED).
>> >    This is a potential and rare case we need to deal with in OS in
>> >    the future.
>> >
>> > Suggested-by: Pavel Machek <pavel@....cz>
>> > Suggested-by: Rafael J. Wysocki <rafael.j.wysocki@...el.com>
>> > Cc: Rafael J. Wysocki <rafael.j.wysocki@...el.com>
>
> Acked-by: Pavel Machek <pavel@....cz>
>
> Rafael, can we get this merged? 12 versions is a bit too much..

We can, if there are no more comments.

It actually doesn't matter how many revisions of the patch there are
as long as it isn't ready ...

Thanks,
Rafael