linux-kernel - Re: [PATCH v2 02/11] tools/power turbostat: Use Intel family processor macros

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1477314612.3927.11.camel@intel.com>
Date:   Mon, 24 Oct 2016 13:15:25 +0000
From:   "Luc, Piotr" <Piotr.Luc@...el.com>
To:     "tglx@...utronix.de" <tglx@...utronix.de>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-pm@...r.kernel.org" <linux-pm@...r.kernel.org>,
        "mchehab@...nel.org" <mchehab@...nel.org>,
        "dougthompson@...ssion.com" <dougthompson@...ssion.com>,
        "x86@...nel.org" <x86@...nel.org>, "hpa@...or.com" <hpa@...or.com>,
        "viresh.kumar@...aro.org" <viresh.kumar@...aro.org>,
        "mingo@...hat.com" <mingo@...hat.com>,
        "rjw@...ysocki.net" <rjw@...ysocki.net>,
        "srinivas.pandruvada@...ux.intel.com" 
        <srinivas.pandruvada@...ux.intel.com>,
        "bp@...en8.de" <bp@...en8.de>, "lenb@...nel.org" <lenb@...nel.org>,
        "linux-edac@...r.kernel.org" <linux-edac@...r.kernel.org>
Subject: Re: [PATCH v2 02/11] tools/power turbostat: Use Intel family
 processor macros

On Fri, 2016-10-14 at 13:56 +0200, Thomas Gleixner wrote:
> On Thu, 13 Oct 2016, Piotr Luc wrote:

> > 
> > +	case INTEL_FAM6_SANDYBRIDGE:		/* SNB */
> 
> Especialy those, which are completely useless?
> 
> The defines are there to be self explaining and the extra verbose
> information should be in the header file defining the macros and not
> in the
> source code.

Hi

I submitted the turbostat patchset 
https://lkml.kernel.org/r/20161018210652.29365-1-piotr.luc@intel.com to
address the issues.

Regards
Piotr