linux-kernel - Re: [PATCH 3/6] sparc64: Initialize iommu_map_table and iommu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20161024.134750.374485400910042905.davem@davemloft.net>
Date:   Mon, 24 Oct 2016 13:47:50 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     tushar.n.dave@...cle.com
Cc:     chris.hyser@...cle.com, sowmini.varadhan@...cle.com,
        vgupta@...opsys.com, robin.murphy@....com, jroedel@...e.de,
        egtvedt@...fundet.no, krzk@...nel.org, rkuo@...eaurora.org,
        sparclinux@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/6] sparc64: Initialize iommu_map_table and iommu_pool

From: Tushar Dave <tushar.n.dave@...cle.com>
Date: Mon, 10 Oct 2016 11:12:04 -0700

> Like legacy IOMMU, use common iommu_map_table and iommu_pool for ATU.
> This change initializes iommu_map_table and iommu_pool for ATU.
> 
> Signed-off-by: Tushar Dave <tushar.n.dave@...cle.com>
> Reviewed-by: chris hyser <chris.hyser@...cle.com>
> Reviewed-by: Sowmini Varadhan <sowmini.varadhan@...cle.com>

I suspect you are adding a bisection problem here.

It looks to me like patch #2 starts setting up to use the ATU
but these changes in #3 and later are necessary for it to even
work properly.

You can't leave the tree in an intermediate non-working state
between changes like that.