linux-kernel - RE: [PATCH v2] drm/arcpgu: Accommodate adv7511 switch to DRM bridge

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 24 Oct 2016 18:33:51 +0000
From:   Alexey Brodkin <Alexey.Brodkin@...opsys.com>
To:     Daniel Vetter <daniel.vetter@...ll.ch>
CC:     "linux-snps-arc@...ts.infradead.org" 
        <linux-snps-arc@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "Eugeniy Paltsev" <Eugeniy.Paltsev@...opsys.com>,
        "dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
        "architt@...eaurora.org" <architt@...eaurora.org>,
        David Airlie <airlied@...ux.ie>,
        Ramiro Oliveira <Ramiro.Oliveira@...opsys.com>
Subject: RE: [PATCH v2] drm/arcpgu: Accommodate adv7511 switch to DRM bridge

Hi Daniel,

> -----Original Message-----
> From: linux-snps-arc [mailto:linux-snps-arc-bounces@...ts.infradead.org] On Behalf Of Alexey Brodkin
> Sent: 19 октября 2016 г. 12:33
> To: dri-devel@...ts.freedesktop.org; architt@...eaurora.org; Eugeniy.Paltsev@...opsys.com
> Cc: linux-snps-arc@...ts.infradead.org; linux-kernel@...r.kernel.org
> Subject: Re: [PATCH v2] drm/arcpgu: Accommodate adv7511 switch to DRM bridge
> 
> Hi Archit, all,
> 
> On Wed, 2016-10-19 at 14:43 +0530, Archit Taneja wrote:
> >
> > On 10/19/2016 01:16 PM, Eugeniy Paltsev wrote:
> > >
> > > ARC PGU driver starts crashing on initialization after
> > > 'commit e12c2f645557 ("drm/i2c: adv7511: Convert to drm_bridge")'
> > > This happenes because in "arcpgu_drm_hdmi_init" function we get pointer
> > > of "drm_i2c_encoder_driver" structure, which doesn't exist after
> > > adv7511 hdmi encoder interface changed from slave encoder to drm bridge.
> > > So, when we call "encoder_init" function from this structure driver
> > > crashes.
> 
> [snip]
> 
> > Looks good now.
> >
> > Reviewed-by: Archit Taneja <architt@...eaurora.org>
> 
> And IMHO it would be really good to get this one back-ported to 4.8
> because it really fixes kernel crash if ARC PGU driver is used.
> 
> It might be a bit of a problem because patch itself a little-bit larger
> than formal requirement for stable backports but let's see if it gets accepted.

Could you please pick this one up?
I may alternatively send a pull-request to David but not sure if 1 patch worth it.

Also if that's not really too late it would be good to get this one in 4.9 since the patch
In question fixes a real driver crash on its instantiation.
Actually driver crash happens since 4.8 but I failed to notice it earlier and given amount
of changes I think there's barely a chance for it it to be accepted in stable branches...
which in its turn makes at least 4.9 very desirable.

-Alexey