linux-kernel - Re: [PATCH] perf hist browser: Fix hierarchy column counts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20161024193811.GD302@x4>
Date:   Mon, 24 Oct 2016 21:38:11 +0200
From:   Markus Trippelsdorf <markus@...ppelsdorf.de>
To:     Namhyung Kim <namhyung@...nel.org>
Cc:     Arnaldo Carvalho de Melo <acme@...nel.org>,
        Ingo Molnar <mingo@...nel.org>,
        Peter Zijlstra <peterz@...radead.org>,
        Jiri Olsa <jolsa@...nel.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] perf hist browser: Fix hierarchy column counts

On 2016.10.24 at 19:00 +0200, Markus Trippelsdorf wrote:
> On 2016.10.25 at 01:21 +0900, Namhyung Kim wrote:
> > The perf report/top on TUI supports horizontal scrolling using LEFT and
> > RIGHT keys.  But it calculate the number of columns incorrectly when
> > hierarchy mode is enabled so that keep pressing RIGHT key can make the
> > output disappeared.  In the hierarchy mode, all sort keys are collapsed
> > into a single column, so it needs to be applied when calculating column
> > numbers.
> 
> Thanks, this is much better now. 
> 
> But it doesn't scroll wide enough. In "perf top" when I press the RIGHT
> key the symbols are shown on the hard left side. In "perf top --hierarchy",
> when I press the RIGHT key, there are 5 empty spaces on the left hand
> side that should be deleted.

It might be a good idea to keep the + and - signs on the left hand side
when scrolling horizontally like "perf report -g" does.

-- 
Markus