linux-kernel - Re: [PATCH 2/6] sparc64: Add ATU (new IOMMU) support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1be31752-6f6d-e28e-9e30-835c8b7b8395@oracle.com>
Date:   Mon, 24 Oct 2016 13:40:06 -0700
From:   tndave <tushar.n.dave@...cle.com>
To:     David Miller <davem@...emloft.net>
Cc:     chris.hyser@...cle.com, sowmini.varadhan@...cle.com,
        vgupta@...opsys.com, robin.murphy@....com, jroedel@...e.de,
        egtvedt@...fundet.no, krzk@...nel.org, rkuo@...eaurora.org,
        sparclinux@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/6] sparc64: Add ATU (new IOMMU) support



On 10/24/2016 10:46 AM, David Miller wrote:
> From: Tushar Dave <tushar.n.dave@...cle.com>
> Date: Mon, 10 Oct 2016 11:12:03 -0700
>
>> +	/* calculate size of IOTSB */
>> +	table_size = (atu->size / IO_PAGE_SIZE) * 8;
>> +	table = kzalloc(table_size, GFP_KERNEL);
>> +	if (!table) {
>> +		err = -ENOMEM;
>> +		goto table_failed;
>> +	}
>> +	table = (void *)IO_PAGE_ALIGN((u64)table);
>
> If you use the page allocator directly you can avoid all of these
> funny alignment calculations.
Okay. I will look into this.
>
>> @@ -931,8 +1046,10 @@ static int pci_sun4v_probe(struct platform_device *op)
>>  	struct pci_pbm_info *pbm;
>>  	struct device_node *dp;
>>  	struct iommu *iommu;
>> +	struct atu *atu;
>>  	u32 devhandle;
>>  	int i, err = -ENODEV;
>> +	static bool hv_atu = 1;
>
> Please use true/false with boolean variables.
Sure.
>
>> +			hv_atu = 0;
>
> Likewise.
>
Thanks.
-Tushar