linux-kernel - Re: [PATCH] drm/amd/powerplay: mark symbols static where possible

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6582910.6C6abby7Jc@wuerfel>
Date:   Mon, 24 Oct 2016 22:51:07 +0200
From:   Arnd Bergmann <arnd@...db.de>
To:     Baoyou Xie <baoyou.xie@...aro.org>
Cc:     alexander.deucher@....com, airlied@...ux.ie, Rex.Zhu@....com,
        Jammy.Zhou@....com, JinHuiEric.Huang@....com, tom.stdenis@....com,
        funfunctor@...klore1984.net, vitaly.prosyak@....com,
        eric.yang2@....com, Young.Yang@....com, ray.huang@....com,
        dan.carpenter@...cle.com, Flora.Cui@....com,
        nils.wallmenius@...il.com, Monk.Liu@....com, Qingqing.Wang@....com,
        Frank.Min@....com, dri-devel@...ts.freedesktop.org,
        linux-kernel@...r.kernel.org, xie.baoyou@....com.cn,
        han.fei@....com.cn, tang.qiang007@....com.cn
Subject: Re: [PATCH] drm/amd/powerplay: mark symbols static where possible

On Saturday, October 22, 2016 4:56:22 PM CEST Baoyou Xie wrote:
> @@ -1341,7 +1341,7 @@ int smu7_disable_dpm_tasks(struct pp_hwmgr *hwmgr)
>         return result;
>  }
>  
> -int smu7_reset_asic_tasks(struct pp_hwmgr *hwmgr)
> +static int smu7_reset_asic_tasks(struct pp_hwmgr *hwmgr)
>  {
>  
>         return 0;
> 

This needs to be done differently:

../drivers/gpu/drm/amd/amdgpu/../powerplay/hwmgr/smu7_hwmgr.c:1344:12: error: 'smu7_reset_asic_tasks' defined but not used [-Werror=unused-function]

The function has no callers, so the easiest way would be to remove it
entirely, but it's possible that there are plans to add users soon.

	Arnd