linux-kernel - Re: [PATCH] drm/amd/powerplay: mark symbols static where possible

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <10254575.qBa8RMPyZ5@wuerfel>
Date:   Tue, 25 Oct 2016 10:15:06 +0200
From:   Arnd Bergmann <arnd@...db.de>
To:     Baoyou Xie <baoyou.xie@...aro.org>
Cc:     "Deucher, Alexander" <alexander.deucher@....com>,
        Dave Airlie <airlied@...ux.ie>, "Zhu, Rex" <Rex.Zhu@....com>,
        "Zhou, Jammy" <Jammy.Zhou@....com>,
        "Huang, JinHuiEric" <JinHuiEric.Huang@....com>,
        "StDenis, Tom" <tom.stdenis@....com>,
        Edward O'Callaghan <funfunctor@...klore1984.net>,
        "Prosyak, Vitaly" <vitaly.prosyak@....com>,
        "Yang, Eric" <eric.yang2@....com>,
        "Yang, Young" <Young.Yang@....com>, Huang Rui <ray.huang@....com>,
        Dan Carpenter <dan.carpenter@...cle.com>,
        "Cui, Flora" <Flora.Cui@....com>,
        Nils Wallménius <nils.wallmenius@...il.com>,
        "Liu, Monk" <Monk.Liu@....com>, Qingqing.Wang@....com,
        "Min, Frank" <Frank.Min@....com>,
        dri-devel <dri-devel@...ts.freedesktop.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        xie.baoyou@....com.cn, han.fei@....com.cn, tang.qiang007@....com.cn
Subject: Re: [PATCH] drm/amd/powerplay: mark symbols static where possible

On Tuesday, October 25, 2016 10:31:21 AM CEST Baoyou Xie wrote:
> On 25 October 2016 at 04:51, Arnd Bergmann <arnd@...db.de> wrote:
> > On Saturday, October 22, 2016 4:56:22 PM CEST Baoyou Xie wrote:
> > The function has no callers, so the easiest way would be to remove it
> > entirely, but it's possible that there are plans to add users soon.
> >
> > It was assumed that this function will be used soon, so this patch remains
> it.
> if it still not be used in 4.10, then we can remove it.
> is it right?

There is no such rule in general, it's up to the maintainer and
it depends on the specific reason for why the function ended up
being unused in the first place.

However, we can expect the maintainer to come up with some solution
to address the warning. Possible options include:

- calling the function from where it was meant to be used
- removing the function
- adding __maybe_unused
- adding an #if 0

I have not looked at this specific example and do not know
which of them would be appropriate here. If you look at the
output of 'git log -p drivers/gpu/drm/amd/amdgpu/../powerplay/hwmgr/smu7_hwmgr.c'
you might find it out yourself.

	Arnd