linux-kernel - Re: [PATCH/RFT v2 08/17] ARM: davinci: hawk: add full constraints for ohci plat boot

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <522eeb9a-6fb1-88eb-5c58-7ee209a50fc3@ti.com>
Date:   Tue, 25 Oct 2016 15:58:53 +0530
From:   Sekhar Nori <nsekhar@...com>
To:     <ahaslam@...libre.com>, <gregkh@...uxfoundation.org>,
        <johan@...nel.org>, <robh+dt@...nel.org>,
        <stern@...land.harvard.edu>, <khilman@...libre.com>,
        <sshtylyov@...mvista.com>, <david@...hnology.com>,
        <manjunath.goudar@...aro.org>, <broonie@...nel.org>,
        <abailon@...libre.com>
CC:     <linux-usb@...r.kernel.org>, <devicetree@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH/RFT v2 08/17] ARM: davinci: hawk: add full constraints for
 ohci plat boot

On Monday 24 October 2016 10:16 PM, ahaslam@...libre.com wrote:
> From: Axel Haslam <ahaslam@...libre.com>
> 
> The phy framework requests an optional "phy" regulator. If it does
> not find one, it returns -EPROBE_DEFER. In the case of non-DT based boot
> for the omap138-lcdk board, this would prevent the usb11 phy to probe
> correctly and ohci would not enumerate.
> 
> By calling "regulator_has_full_constraints", An error would be returned

nit: prefer regulator_has_full_constraints()

> instead of DEFER for the "optional" regulator, and the probe of
> the phy driver can continue normally without a regulator.
> 
> Signed-off-by: Axel Haslam <ahaslam@...libre.com>

Looks good to me. Just drop the "hawk: from subject line since you also
touch da830 evm. I am not sure what "ohci plat boot" means. How about
the following:

"ARM: davinci: da8xx: fix OHCI PHY probe for non-DT boot"

Thanks,
Sekhar