linux-kernel - Re: [PATCH v2] gpio: of: fix GPIO drivers with multiple gpio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACRpkdYZaOjQ0ctg54w2hJisPcr7RJH4QRsman04Ejsjnci3Jw@mail.gmail.com>
Date:   Tue, 25 Oct 2016 14:09:44 +0200
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Masahiro Yamada <yamada.masahiro@...ionext.com>
Cc:     "linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
        Vladimir Zapolskiy <vz@...ia.com>,
        Alexandre Courbot <gnurou@...il.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] gpio: of: fix GPIO drivers with multiple gpio_chip for
 a single node

On Tue, Oct 25, 2016 at 3:47 AM, Masahiro Yamada
<yamada.masahiro@...ionext.com> wrote:

> Sylvain Lemieux reports the LPC32xx GPIO driver is broken since
> commit 762c2e46c059 ("gpio: of: remove of_gpiochip_and_xlate() and
> struct gg_data").  Probably, gpio-etraxfs.c and gpio-davinci.c are
> broken too.
>
> Those drivers register multiple gpio_chip that are associated to a
> single OF node, and their own .of_xlate() checks if the passed
> gpio_chip is valid.
>
> Now, the problem is of_find_gpiochip_by_node() returns the first
> gpio_chip found to match the given node.  So, .of_xlate() fails,
> except for the first GPIO bank.
>
> Reverting the commit could be a solution, but I do not want to go
> back to the mess of struct gg_data.  Another solution here is to
> take the match by a node pointer and the success of .of_xlate().
> It is a bit clumsy to call .of_xlate twice; for gpio_chip matching
> and for really getting the gpio_desc index.  Perhaps, our long-term
> goal might be to convert the drivers to single chip registration,
> but this commit will solve the problem until then.
>
> Fixes: 762c2e46c059 ("gpio: of: remove of_gpiochip_and_xlate() and struct gg_data")
> Signed-off-by: Masahiro Yamada <yamada.masahiro@...ionext.com>
> Reported-by: Sylvain Lemieux <slemieux.tyco@...il.com>
> Tested-by: David Lechner <david@...hnology.com>
> ---
>
> Changes in v2:
>   - correcton pointed out by Sylvain:
>        chip->of_xlate(chip, gpiospec, NULL) >= 0

Patch applied for fixes.

Yours,
Linus Walleij