linux-kernel - [PATCH] gpio: gpiolib-devprop: Check chip->parent pointer before dereferencing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <1477413083-9159-1-git-send-email-tthayer@opensource.altera.com>
Date:   Tue, 25 Oct 2016 11:31:23 -0500
From:   <tthayer@...nsource.altera.com>
To:     <linus.walleij@...aro.org>, <gnurou@...il.com>,
        <mika.westerberg@...ux.intel.com>
CC:     <linux-gpio@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <tthayer@...nsource.altera.com>
Subject: [PATCH] gpio: gpiolib-devprop: Check chip->parent pointer before dereferencing

From: Thor Thayer <tthayer@...nsource.altera.com>

Confirm the chip->parent is valid before dereferencing because
the parent parameter is optional.

Signed-off-by: Thor Thayer <tthayer@...nsource.altera.com>
---
 drivers/gpio/gpiolib-devprop.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/drivers/gpio/gpiolib-devprop.c b/drivers/gpio/gpiolib-devprop.c
index 17bfc41..27f383b 100644
--- a/drivers/gpio/gpiolib-devprop.c
+++ b/drivers/gpio/gpiolib-devprop.c
@@ -31,6 +31,11 @@ void devprop_gpiochip_set_names(struct gpio_chip *chip)
 	const char **names;
 	int ret, i;
 
+	if (!chip->parent) {
+		dev_warn(&gdev->dev, "GPIO chip parent is NULL\n");
+		return;
+	}
+
 	ret = device_property_read_string_array(chip->parent, "gpio-line-names",
 						NULL, 0);
 	if (ret < 0)
-- 
1.9.1