linux-kernel - [tip:x86/microcode] x86/microcode: Issue the debug printk on resume only on success

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <tip-6b14b81899a2e1e5dd0d089f2a41a6118929658d@git.kernel.org>
Date:   Tue, 25 Oct 2016 09:30:45 -0700
From:   tip-bot for Borislav Petkov <tipbot@...or.com>
To:     linux-tip-commits@...r.kernel.org
Cc:     dvlasenk@...hat.com, linux-kernel@...r.kernel.org, hpa@...or.com,
        brgerst@...il.com, tglx@...utronix.de, jpoimboe@...hat.com,
        bp@...en8.de, peterz@...radead.org, bp@...e.de, luto@...nel.org,
        torvalds@...ux-foundation.org, mingo@...nel.org
Subject: [tip:x86/microcode] x86/microcode: Issue the debug printk on resume
 only on success

Commit-ID:  6b14b81899a2e1e5dd0d089f2a41a6118929658d
Gitweb:     http://git.kernel.org/tip/6b14b81899a2e1e5dd0d089f2a41a6118929658d
Author:     Borislav Petkov <bp@...e.de>
AuthorDate: Tue, 25 Oct 2016 11:55:17 +0200
Committer:  Ingo Molnar <mingo@...nel.org>
CommitDate: Tue, 25 Oct 2016 12:28:58 +0200

x86/microcode: Issue the debug printk on resume only on success

Move it after the patch application function which also checks whether
we were successful.

Signed-off-by: Borislav Petkov <bp@...e.de>
Cc: Andy Lutomirski <luto@...nel.org>
Cc: Borislav Petkov <bp@...en8.de>
Cc: Brian Gerst <brgerst@...il.com>
Cc: Denys Vlasenko <dvlasenk@...hat.com>
Cc: H. Peter Anvin <hpa@...or.com>
Cc: Josh Poimboeuf <jpoimboe@...hat.com>
Cc: Linus Torvalds <torvalds@...ux-foundation.org>
Cc: Peter Zijlstra <peterz@...radead.org>
Cc: Thomas Gleixner <tglx@...utronix.de>
Link: http://lkml.kernel.org/r/20161025095522.11964-8-bp@alien8.de
Signed-off-by: Ingo Molnar <mingo@...nel.org>
---
 arch/x86/kernel/cpu/microcode/core.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/x86/kernel/cpu/microcode/core.c b/arch/x86/kernel/cpu/microcode/core.c
index b67145d..a18ff75 100644
--- a/arch/x86/kernel/cpu/microcode/core.c
+++ b/arch/x86/kernel/cpu/microcode/core.c
@@ -460,11 +460,11 @@ static void microcode_fini_cpu(int cpu)
 
 static enum ucode_state microcode_resume_cpu(int cpu)
 {
-	pr_debug("CPU%d updated upon resume\n", cpu);
-
 	if (apply_microcode_on_target(cpu))
 		return UCODE_ERROR;
 
+	pr_debug("CPU%d updated upon resume\n", cpu);
+
 	return UCODE_OK;
 }