linux-kernel - Re: [RFC/PATCH 2/2] perf sched: Make common options cascading

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20161025172132.GD4543@kernel.org>
Date:   Tue, 25 Oct 2016 14:21:32 -0300
From:   Arnaldo Carvalho de Melo <acme@...nel.org>
To:     Jiri Olsa <jolsa@...hat.com>
Cc:     Namhyung Kim <namhyung@...nel.org>, Ingo Molnar <mingo@...nel.org>,
        Peter Zijlstra <a.p.zijlstra@...llo.nl>,
        Jiri Olsa <jolsa@...nel.org>,
        LKML <linux-kernel@...r.kernel.org>,
        David Ahern <dsahern@...il.com>,
        Andi Kleen <andi@...stfloor.org>,
        Wang Nan <wangnan0@...wei.com>,
        Josh Poimboeuf <jpoimboe@...hat.com>
Subject: Re: [RFC/PATCH 2/2] perf sched: Make common options cascading

Em Mon, Oct 24, 2016 at 07:03:32PM +0200, Jiri Olsa escreveu:
> On Mon, Oct 24, 2016 at 12:00:03PM +0900, Namhyung Kim wrote:
> > The -i and -v options can be used in subcommands so enable cascading the
> > sched_options.  This fixes the following inconvenience in 'perf sched':
> > 
> >   $ perf sched -i perf.data.sched  map
> >   ... (it works well) ...
> > 
> >   $ perf sched map  -i perf.data.sched
> >     Error: unknown switch `i'
> > 
> >    Usage: perf sched map [<options>]
> > 
> >           --color-cpus <cpus>
> >                             highlight given CPUs in map
> >           --color-pids <pids>
> >                             highlight given pids in map
> >           --compact         map output in compact mode
> >           --cpus <cpus>     display given CPUs in map
> > 
> > With this patch, the second command line works with the perf.data.sched
> > data file.
> > 
> > Cc: Josh Poimboeuf <jpoimboe@...hat.com>
> > Signed-off-by: Namhyung Kim <namhyung@...nel.org>
> 
> good idea, I'll use it in c2c ;-)
> 
> for both:
> 
> Acked-by: Jiri Olsa <jolsa@...nel.org>

Applied, I guess 'perf kvm' would be another user, to make it sane wrt
file_name, -i and -o being available for 'perf kvm record', etc.

- Arnaldo