[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-Id: <20161025184440.4274-1-colin.king@canonical.com>
Date: Tue, 25 Oct 2016 19:44:40 +0100
From: Colin King <colin.king@...onical.com>
To: Lars-Peter Clausen <lars@...afoo.de>,
Michael Hennerich <Michael.Hennerich@...log.com>,
Jonathan Cameron <jic23@...nel.org>,
Hartmut Knaack <knaack.h@....de>,
Peter Meerwald-Stadler <pmeerw@...erw.net>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
linux-iio@...r.kernel.org, devel@...verdev.osuosl.org
Cc: linux-kernel@...r.kernel.org
Subject: [PATCH] staging: iio: cdc: ad7746: set ret on IIO_VOLTAGE case
From: Colin Ian King <colin.king@...onical.com>
For a IIO_VOLTAGE case, ret is not being set causing an
uninitialized value being returned by ad7746_read_raw. Fix
this by setting ret to IIO_VAL_INT for this specific case.
Signed-off-by: Colin Ian King <colin.king@...onical.com>
---
drivers/staging/iio/cdc/ad7746.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/iio/cdc/ad7746.c b/drivers/staging/iio/cdc/ad7746.c
index f41251c..a5828f9 100644
--- a/drivers/staging/iio/cdc/ad7746.c
+++ b/drivers/staging/iio/cdc/ad7746.c
@@ -642,6 +642,7 @@ static int ad7746_read_raw(struct iio_dev *indio_dev,
case IIO_VOLTAGE:
*val = ad7746_vt_filter_rate_table[
(chip->config >> 6) & 0x3][0];
+ ret = IIO_VAL_INT;
break;
default:
ret = -EINVAL;
--
2.9.3
Powered by blists - more mailing lists