linux-kernel - Re: [RFC] shutdown machine when li-ion battery goes below 3V

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <E1bz7FE-0007t1-Tp@bigred.inka.de>
Date:   Tue, 25 Oct 2016 21:18:46 +0200
From:   Olaf Titz <olaf@...red.inka.de>
To:     linux-kernel@...r.kernel.org
Subject: Re: [RFC] shutdown machine when li-ion battery goes below 3V

> +	res = bq27xxx_battery_voltage(di, &val);
> +	if (res)
> +		return res;
> +
> +	mV = val.intval / 1000;

Reading that code I stumbled over the comment in
bq27xxx_battery_voltage saying that it returns millivolts. The code
here, the code in bq27xxx_battery_voltage and power_supply.h all
indicate that it in fact returns microvolts. Please double-check and
fix, as it stands now the code looks inconsistent (but not knowing that
device at all I don't feel fit to submit a fix).

regards, Olaf