linux-kernel - Re: [PATCH] batman-adv: Revert "use core MTU range checking in misc drivers"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20161026.172014.1445485460255687424.davem@davemloft.net>
Date:   Wed, 26 Oct 2016 17:20:14 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     sven@...fation.org
Cc:     netdev@...r.kernel.org, b.a.t.m.a.n@...ts.open-mesh.org,
        linux-kernel@...r.kernel.org, jarod@...hat.com
Subject: Re: [PATCH] batman-adv: Revert "use core MTU range checking in
 misc drivers"

From: Sven Eckelmann <sven@...fation.org>
Date: Sat, 22 Oct 2016 09:46:24 +0200

> The maximum MTU is defined via the slave devices of an batman-adv
> interface. Thus it is not possible to calculate the max_mtu during the
> creation of the batman-adv device when no slave devices are attached. Doing
> so would for example break non-fragmentation setups which then
> (incorrectly) allow an MTU of 1500 even when underlying device cannot
> transport 1500 bytes + batman-adv headers.
> 
> Checking the dynamically calculated max_mtu via the minimum of the slave
> devices MTU during .ndo_change_mtu is also used by the bridge interface.
> 
> Cc: Jarod Wilson <jarod@...hat.com>
> Fixes: b3e3893e1253 ("net: use core MTU range checking in misc drivers")
> Signed-off-by: Sven Eckelmann <sven@...fation.org>

Applied, thanks.