linux-kernel - Re: CONFIG_VMAP_STACK, on-stack struct, and wake_up

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+55aFxfb-kY40P4HgYnhehx--TuwV7K7C4J4jdx9nan7u0s1A@mail.gmail.com>
Date:   Wed, 26 Oct 2016 14:30:49 -0700
From:   Linus Torvalds <torvalds@...ux-foundation.org>
To:     Bob Peterson <rpeterso@...hat.com>, Borislav Petkov <bp@...e.de>
Cc:     Andy Lutomirski <luto@...capital.net>,
        Andreas Gruenbacher <agruenba@...hat.com>,
        Peter Zijlstra <peterz@...radead.org>,
        Andy Lutomirski <luto@...nel.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Steven Whitehouse <swhiteho@...hat.com>,
        Mel Gorman <mgorman@...hsingularity.net>,
        linux-mm <linux-mm@...ck.org>
Subject: Re: CONFIG_VMAP_STACK, on-stack struct, and wake_up_bit

On Wed, Oct 26, 2016 at 2:01 PM, Bob Peterson <rpeterso@...hat.com> wrote:
>
> Hm. It didn't even boot, at least on my amd box in the lab.
> I've made no attempt to debug this.

Hmm. Looks like a completely independent issue from the patch. Did you
try booting that machine without the patch?

> [    2.378877] kernel BUG at arch/x86/mm/physaddr.c:26!

Ok, similar issue, I think - passing a non-1:1 address to __phys_addr().

But the call trace has nothing to do with gfs2 or the bitlocks:

> [    2.504561] Call Trace:
> [    2.507005]   save_microcode_in_initrd_amd+0x31/0x106
> [    2.513778]   save_microcode_in_initrd+0x3c/0x45
> [    2.526110]   do_one_initcall+0x50/0x180
> [    2.531756]   ? set_debug_rodata+0x12/0x12
> [    2.537573]   kernel_init_freeable+0x194/0x230
> [    2.543740]   ? rest_init+0x80/0x80
> [    2.548952]   kernel_init+0xe/0x100
> [    2.554164]   ret_from_fork+0x25/0x30

I think this might be the

        cont    = __pa(container);

line in save_microcode_in_initrd_amd().

I see that Borislav is busy with some x86/microcode patches, I suspect
he already hit this. Adding Borislav to the cc.

Can you re-try without the AMD microcode driver for now? This seems to
be a separate issue from the gfs2 one.

               Linus