linux-kernel - Re: [RESEND PATCH v4] clk: x86: Add Atom PMC platform clocks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 26 Oct 2016 15:02:12 -0700
From:   Darren Hart <dvhart@...radead.org>
To:     Thomas Gleixner <tglx@...utronix.de>
Cc:     "Tirdea, Irina" <irina.tirdea@...el.com>,
        "linux-clk@...r.kernel.org" <linux-clk@...r.kernel.org>,
        "x86@...nel.org" <x86@...nel.org>,
        Stephen Boyd <sboyd@...eaurora.org>,
        Ingo Molnar <mingo@...hat.com>,
        Michael Turquette <mturquette@...libre.com>,
        "H. Peter Anvin" <hpa@...or.com>,
        "alsa-devel@...a-project.org" <alsa-devel@...a-project.org>,
        Mark Brown <broonie@...nel.org>, Takashi Iwai <tiwai@...e.com>,
        "Bossart, Pierre-louis" <pierre-louis.bossart@...el.com>,
        LKML <linux-kernel@...r.kernel.org>,
        Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>
Subject: Re: [RESEND PATCH v4] clk: x86: Add Atom PMC platform clocks

On Wed, Oct 26, 2016 at 11:43:24PM +0200, Thomas Gleixner wrote:
> On Wed, 26 Oct 2016, Darren Hart wrote:
> > On Mon, Oct 24, 2016 at 01:38:54PM +0000, Tirdea, Irina wrote:
> > > intel_pmc_* drivers or is it enough to move it as a standalone driver for now?
> > 
> > If the functionality is substantially different, then I don't see a
> > compelling, and certainly not an immediate, need to merge them. Assume
> > for now they are to remain as separate drivers. I suggest keeping the
> > existing name for now as well. Let's just complete the move with as
> > little user-visible changes as possible.
> > 
> > The placement of the header file is a bit tricky as it is being used in
> > drivers/clk/x86 in addition to the pmc_atom driver in
> > drivers/platform/x86.
> > 
> > The best existing location would appear to be include/platform_data/
> > 
> > Thomas, is that acceptable to you?
> 
> Yes
> 
> > arch/x86/platform/atom/pmc_atom.c -> drivers/platform/x86
> > arch/x86/include/asm/pmc_atom.h -> include/platform_data/
> > 
> > If there are enough of these, it might make sense to create:
> > 
> > include/platform/x86/
> > 
> > but I suggest we start with minimal change.
> 
> No. Make that x86 directory right away. include/platform_data is already a
> maze of 224 files. Start structuring it now.

OK, that's fine with me too.

(but I typo'd, should have been: include/linux/platform_data/x86)

Irina, does this give you enough to go on?

-- 
Darren Hart
Intel Open Source Technology Center