linux-kernel - Re: [tip:x86/cpu] x86/cpu: Get rid of the show

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAE9FiQWeinByZf3CKcnvnrcybDtJGam5WHT744ZW_ixm2GJFbw@mail.gmail.com>
Date:   Wed, 26 Oct 2016 15:25:02 -0700
From:   Yinghai Lu <yinghai@...nel.org>
To:     Josh Poimboeuf <jpoimboe@...hat.com>,
        "H. Peter Anvin" <hpa@...or.com>,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        Borislav Petkov <bp@...en8.de>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Brian Gerst <brgerst@...il.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Borislav Petkov <bp@...e.de>,
        Peter Zijlstra <peterz@...radead.org>,
        Denys Vlasenko <dvlasenk@...hat.com>,
        Ingo Molnar <mingo@...nel.org>,
        Andy Lutomirski <luto@...nel.org>
Cc:     "linux-tip-commits@...r.kernel.org" 
        <linux-tip-commits@...r.kernel.org>
Subject: Re: [tip:x86/cpu] x86/cpu: Get rid of the show_msr= boot option

On Tue, Oct 25, 2016 at 3:34 AM, tip-bot for Borislav Petkov
<tipbot@...or.com> wrote:
> Commit-ID:  59c6f278bdeea4147e8be92a3ed50a9907e60088
> Gitweb:     http://git.kernel.org/tip/59c6f278bdeea4147e8be92a3ed50a9907e60088
> Author:     Borislav Petkov <bp@...e.de>
> AuthorDate: Mon, 24 Oct 2016 19:38:44 +0200
> Committer:  Ingo Molnar <mingo@...nel.org>
> CommitDate: Tue, 25 Oct 2016 11:48:50 +0200
>
> x86/cpu: Get rid of the show_msr= boot option
>
> It is useless as it dumps the MSRs too early BUT(!) we do set MSRs later too.

So that is reason that was added to print the MSR early before kernel
try to change it.

> Also, it dumps only BSP MSRs as it gets called only for CPU 0.

I sent the fix last year.

https://patchwork.kernel.org/patch/6739171/

Yinghai