linux-kernel - Re: [PATCH v2] drm/fb-helper: Don't call dirty callback for untouched clips

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20161026083228.u7xhhiuo4a5m7hff@phenom.ffwll.local>
Date:   Wed, 26 Oct 2016 10:32:28 +0200
From:   Daniel Vetter <daniel@...ll.ch>
To:     Takashi Iwai <tiwai@...e.de>
Cc:     Daniel Vetter <daniel@...ll.ch>,
        Ville Syrjälä 
        <ville.syrjala@...ux.intel.com>, dri-devel@...ts.freedesktop.org,
        linux-kernel@...r.kernel.org,
        Noralf Trønnes <noralf@...nnes.org>,
        David Airlie <airlied@...ux.ie>
Subject: Re: [PATCH v2] drm/fb-helper: Don't call dirty callback for
 untouched clips

On Tue, Oct 25, 2016 at 10:17:47AM +0200, Takashi Iwai wrote:
> On Tue, 25 Oct 2016 10:09:30 +0200,
> Daniel Vetter wrote:
> > 
> > On Tue, Oct 25, 2016 at 08:46:28AM +0200, Takashi Iwai wrote:
> > > On Fri, 21 Oct 2016 14:52:07 +0200,
> > > Ville Syrjälä wrote:
> > > > 
> > > > On Thu, Oct 20, 2016 at 05:05:30PM +0200, Takashi Iwai wrote:
> > > > > Since 4.7 kernel, we've seen the error messages like
> > > > > 
> > > > >  kernel: [TTM] Buffer eviction failed
> > > > >  kernel: qxl 0000:00:02.0: object_init failed for (4026540032, 0x00000001)
> > > > >  kernel: [drm:qxl_alloc_bo_reserved [qxl]] *ERROR* failed to allocate VRAM BO
> > > > > 
> > > > > on QXL when switching and accessing on VT.  The culprit was the
> > > > > generic deferred_io code (qxl driver switched to it since 4.7).
> > > > > There is a race between the dirty clip update and the call of
> > > > > callback.
> > > > > 
> > > > > In drm_fb_helper_dirty(), the dirty clip is updated in the spinlock,
> > > > > while it kicks off the update worker outside the spinlock.  Meanwhile
> > > > > the update worker clears the dirty clip in the spinlock, too.  Thus,
> > > > > when drm_fb_helper_dirty() is called concurrently, schedule_work() is
> > > > > called after the clip is cleared in the first worker call.
> > > > > 
> > > > > This patch addresses it by validating the clip before calling the
> > > > > dirty fb callback.
> > > > > 
> > > > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=98322
> > > > > Bugzilla: https://bugzilla.suse.com/show_bug.cgi?id=1003298
> > > > > Fixes: eaa434defaca ('drm/fb-helper: Add fb_deferred_io support')
> > > > > Cc: <stable@...r.kernel.org>
> > > > > Signed-off-by: Takashi Iwai <tiwai@...e.de>
> > > > 
> > > > Reviewed-by: Ville Syrjälä <ville.syrjala@...ux.intel.com>
> > > 
> > > Daniel, could you pick this if it's OK as a quick fix?  Currently
> > > qxl driver is utterly broken, and we should recover it ASAP.  On top
> > > of this, we can put a more comprehensive fix covering both this and
> > > dirtyfb ioctl code paths.
> > 
> > I thought I've pinged Dave already to pick up, I'll poke him again.
> 
> Thanks!

Ok, trying something new, thrown into drm-misc-fixes.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch