linux-kernel - Re: [PATCH 1/2] perf, x86-mm: Add exit-fault tracing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20161026085116.GZ3102@twins.programming.kicks-ass.net>
Date:   Wed, 26 Oct 2016 10:51:16 +0200
From:   Peter Zijlstra <peterz@...radead.org>
To:     Alexis Berlemont <alexis.berlemont@...il.com>
Cc:     linux-kernel@...r.kernel.org, mingo@...hat.com, acme@...nel.org,
        alexander.shishkin@...ux.intel.com
Subject: Re: [PATCH 1/2] perf, x86-mm: Add exit-fault tracing

On Wed, Oct 26, 2016 at 01:51:59AM +0200, Alexis Berlemont wrote:

-ENOCHANGELOG

> Signed-off-by: Alexis Berlemont <alexis.berlemont@...il.com>
> ---

> diff --git a/arch/x86/mm/fault.c b/arch/x86/mm/fault.c
> index 9f72ca3..e31e8ef 100644
> --- a/arch/x86/mm/fault.c
> +++ b/arch/x86/mm/fault.c
> @@ -1488,6 +1488,7 @@ trace_do_page_fault(struct pt_regs *regs, unsigned long error_code)
>  	prev_state = exception_enter();
>  	trace_page_fault_entries(address, regs, error_code);
>  	__do_page_fault(regs, error_code, address);
> +	trace_page_fault_exit(address);

Aside from my general hatred of tracepoint, it bugs me that its not
symmetric like the irq vector ones. But I'll leave that to x86 people.

>  	exception_exit(prev_state);
>  }
>  NOKPROBE_SYMBOL(trace_do_page_fault);
> -- 
> 2.10.1
>