linux-kernel - Re: [PATCH v14 5/9] clocksource/drivers/arm_arch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CADyBb7ukv4boB7iSt3cxr6SQK_KNsSirAWuP4J+zU-=E2QaEQA@mail.gmail.com>
Date:   Wed, 26 Oct 2016 16:54:48 +0800
From:   Fu Wei <fu.wei@...aro.org>
To:     Mark Rutland <mark.rutland@....com>
Cc:     Linaro ACPI Mailman List <linaro-acpi@...ts.linaro.org>,
        Catalin Marinas <catalin.marinas@....com>,
        Will Deacon <will.deacon@....com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Julien Grall <julien.grall@....com>,
        Wei Huang <wei@...hat.com>,
        Lorenzo Pieralisi <lorenzo.pieralisi@....com>,
        Al Stone <al.stone@...aro.org>,
        Tomasz Nowicki <tn@...ihalf.com>,
        Timur Tabi <timur@...eaurora.org>,
        Daniel Lezcano <daniel.lezcano@...aro.org>,
        ACPI Devel Maling List <linux-acpi@...r.kernel.org>,
        Guenter Roeck <linux@...ck-us.net>,
        Len Brown <lenb@...nel.org>,
        "Abdulhamid, Harb" <harba@...eaurora.org>,
        linux-watchdog@...r.kernel.org, Arnd Bergmann <arnd@...db.de>,
        Marc Zyngier <marc.zyngier@....com>,
        Jon Masters <jcm@...hat.com>,
        Sudeep Holla <sudeep.holla@....com>,
        Christopher Covington <cov@...eaurora.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        linux-arm-kernel@...ts.infradead.org,
        G Gregory <graeme.gregory@...aro.org>,
        "Rafael J. Wysocki" <rjw@...ysocki.net>, rruigrok@...eaurora.org,
        Leo Duran <leo.duran@....com>,
        Hanjun Guo <hanjun.guo@...aro.org>,
        Suravee Suthikulpanit <Suravee.Suthikulpanit@....com>,
        Wim Van Sebroeck <wim@...ana.be>,
        Christoffer Dall <christoffer.dall@...aro.org>
Subject: Re: [PATCH v14 5/9] clocksource/drivers/arm_arch_timer: Simplify ACPI
 support code.

Hi Mark,

On 21 October 2016 at 19:21, Mark Rutland <mark.rutland@....com> wrote:
> On Fri, Oct 21, 2016 at 12:14:01PM +0100, Mark Rutland wrote:
>> On Thu, Oct 20, 2016 at 05:58:17PM +0100, Mark Rutland wrote:
>> > On Thu, Sep 29, 2016 at 02:17:13AM +0800, fu.wei@...aro.org wrote:
>> > > + arch_timer_ppi[PHYS_NONSECURE_PPI] = acpi_gtdt_map_ppi(PHYS_NONSECURE_PPI);
>> > > + arch_timer_ppi[VIRT_PPI] = acpi_gtdt_map_ppi(VIRT_PPI);
>> > > + arch_timer_ppi[HYP_PPI] = acpi_gtdt_map_ppi(HYP_PPI);
>> > > + /* Always-on capability */
>> > > + arch_timer_c3stop = acpi_gtdt_c3stop();
>> >
>> > ... I think we should check the flag on the relevant interrupt, though
>> > that's worth clarifying.
>>
>> I see I misread the spec; this is part of the common flags.
>>
>> Please ignore this point; sorry for the noise.
>
> Actually, I misread the spec this time around; the flag *can* differ per
> interrupt for the sysreg/cp15 timer, but not for the MMIO timers where
> the flag is in a common field.
>
> So please *do* consider the above.

yes , you are right , will do
Thanks :-)

>
> Thanks,
> Mark.



-- 
Best regards,

Fu Wei
Software Engineer
Red Hat