linux-kernel - Re: [PATCH v1] I2C Designware Core Supports SMBUS BLOCK

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20161026093034.GO1476@lahna.fi.intel.com>
Date:   Wed, 26 Oct 2016 12:30:34 +0300
From:   Mika Westerberg <mika.westerberg@...ux.intel.com>
To:     Tin Huynh <tnhuynh@....com>
Cc:     Jarkko Nikula <jarkko.nikula@...ux.intel.com>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Wolfram Sang <wsa@...-dreams.de>, linux-i2c@...r.kernel.org,
        linux-kernel@...r.kernel.org, Loc Ho <lho@....com>,
        Thang Nguyen <tqnguyen@....com>, Phong Vo <pvo@....com>,
        patches <patches@....com>
Subject: Re: [PATCH v1] I2C Designware Core Supports SMBUS BLOCK

On Wed, Oct 26, 2016 at 04:20:57PM +0700, Tin Huynh wrote:
>    We need to set stop bit if three conditions are true :  The latest
>    bytes , the latest msg_write_ids and after receiving the buffer length.
>    If we use i2c_dw_xfer_need_stop , arguments of function are complex.

OK, so you would need to pass dev and buf_len to that.

>    Can i use i2c_dw_xfer_receive_length() function  ?
>    Thank  you and best regards
>    Tin
>                       if (dev->msg_write_idx == dev->msgs_num - 1 &&
>    -                           buf_len == 1)
>    +                           buf_len == 1 && !(flags & I2C_M_RECV_LEN))
>                                    cmd |= BIT(9);

Maybe it is better if you just do it like the above then.