linux-kernel - Re: [PATCH 3/6 v5] sched: factorize PELT update

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20161026114122.GG3102@twins.programming.kicks-ass.net>
Date:   Wed, 26 Oct 2016 13:41:22 +0200
From:   Peter Zijlstra <peterz@...radead.org>
To:     Vincent Guittot <vincent.guittot@...aro.org>
Cc:     mingo@...nel.org, linux-kernel@...r.kernel.org,
        dietmar.eggemann@....com, yuyang.du@...el.com,
        Morten.Rasmussen@....com, linaro-kernel@...ts.linaro.org,
        pjt@...gle.com, bsegall@...gle.com, kernellwp@...il.com
Subject: Re: [PATCH 3/6 v5] sched: factorize PELT update

On Mon, Oct 17, 2016 at 11:14:10AM +0200, Vincent Guittot wrote:
> @@ -3110,11 +3116,12 @@ static inline void update_load_avg(struct sched_entity *se, int update_tg)
>  	 * Track task load average for carrying it to new CPU after migrated, and
>  	 * track group sched_entity load average for task_h_load calc in migration
>  	 */
> -	__update_load_avg(now, cpu, &se->avg,
> +	if (se->avg.last_update_time && !(flags & SKIP_AGE_LOAD))
> +		__update_load_avg(now, cpu, &se->avg,
>  			  se->on_rq * scale_load_down(se->load.weight),
>  			  cfs_rq->curr == se, NULL);
>  

{ } for any multi line stmt pls.