linux-kernel - Re: [PATCH] KVM: fix OOPS on flush

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20161026140206.73cb1150.cornelia.huck@de.ibm.com>
Date:   Wed, 26 Oct 2016 14:02:06 +0200
From:   Cornelia Huck <cornelia.huck@...ibm.com>
To:     Paolo Bonzini <pbonzini@...hat.com>
Cc:     linux-kernel@...r.kernel.org, kvm@...r.kernel.org,
        bhaktipriya96@...il.com, rkrcmar@...hat.com, stable@...r.kernel.org
Subject: Re: [PATCH] KVM: fix OOPS on flush_work

On Wed, 26 Oct 2016 13:44:50 +0200
Paolo Bonzini <pbonzini@...hat.com> wrote:

> The conversion done by commit 3706feacd007 ("KVM: Remove deprecated
> create_singlethread_workqueue") is broken.  It flushes a single work
> item &irqfd->shutdown instead of all of them, and even worse if there
> is no irqfd on the list then you get a NULL pointer dereference.
> Revert the virt/kvm/eventfd.c part of that patch; to avoid the
> deprecated function, just allocate our own workqueue---it does
> not even have to be unbound---with alloc_workqueue.
> 
> Fixes: 3706feacd007
> Cc: stable@...r.kernel.org
> Signed-off-by: Paolo Bonzini <pbonzini@...hat.com>
> ---
>  virt/kvm/eventfd.c  | 22 +++++++++++++++++++---
>  virt/kvm/kvm_main.c |  6 ++++++
>  2 files changed, 25 insertions(+), 3 deletions(-)

Reviewed-by: Cornelia Huck <cornelia.huck@...ibm.com>