linux-kernel - Re: [PATCH v8 2/6] mfd: lpc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20161026130240.GC12618@dell>
Date:   Wed, 26 Oct 2016 14:02:40 +0100
From:   Lee Jones <lee.jones@...aro.org>
To:     Tan Jui Nee <jui.nee.tan@...el.com>
Cc:     mika.westerberg@...ux.intel.com, heikki.krogerus@...ux.intel.com,
        andriy.shevchenko@...ux.intel.com, tglx@...utronix.de,
        mingo@...hat.com, hpa@...or.com, x86@...nel.org,
        ptyser@...-inc.com, linus.walleij@...aro.org,
        linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org,
        jonathan.yong@...el.com, ong.hock.yu@...el.com,
        tony.luck@...el.com, wan.ahmad.zainie.wan.mohamad@...el.com
Subject: Re: [PATCH v8 2/6] mfd: lpc_ich: Rename lpc-ich driver

On Wed, 12 Oct 2016, Tan Jui Nee wrote:

> This patch follows the example of mfd/wm831x to rename the driver
> from "lpc_ich" to "lpc_ich_core".
> 
> Signed-off-by: Tan Jui Nee <jui.nee.tan@...el.com>
> ---
> Changes in V8:
> 	- Update new file name with lpc_ich_core.c at description of source file.
> 	- Rework Makefile with new source file name lpc_ich_apl.c.
> 
> Changes in V7:
> 	- No change
> 
> Changes in V6:
> 	- none, just a subject line and commit message change.
> 
>  drivers/mfd/Makefile                      | 1 +
>  drivers/mfd/{lpc_ich.c => lpc_ich_core.c} | 2 +-
>  2 files changed, 2 insertions(+), 1 deletion(-)
>  rename drivers/mfd/{lpc_ich.c => lpc_ich_core.c} (99%)
> 
> diff --git a/drivers/mfd/Makefile b/drivers/mfd/Makefile
> index 9834e66..06a91ea 100644
> --- a/drivers/mfd/Makefile
> +++ b/drivers/mfd/Makefile
> @@ -159,6 +159,7 @@ obj-$(CONFIG_PMIC_ADP5520)	+= adp5520.o
>  obj-$(CONFIG_MFD_KEMPLD)	+= kempld-core.o
>  obj-$(CONFIG_MFD_INTEL_QUARK_I2C_GPIO)	+= intel_quark_i2c_gpio.o
>  obj-$(CONFIG_LPC_SCH)		+= lpc_sch.o
> +lpc_ich-objs		:= lpc_ich_core.o
>  obj-$(CONFIG_LPC_ICH)		+= lpc_ich.o
>  obj-$(CONFIG_MFD_RDC321X)	+= rdc321x-southbridge.o
>  obj-$(CONFIG_MFD_JANZ_CMODIO)	+= janz-cmodio.o
> diff --git a/drivers/mfd/lpc_ich.c b/drivers/mfd/lpc_ich_core.c
> similarity index 99%
> rename from drivers/mfd/lpc_ich.c
> rename to drivers/mfd/lpc_ich_core.c
> index c8dee47..01d8d9e 100644
> --- a/drivers/mfd/lpc_ich.c
> +++ b/drivers/mfd/lpc_ich_core.c
> @@ -1,5 +1,5 @@
>  /*
> - *  lpc_ich.c - LPC interface for Intel ICH
> + *  lpc_ich_core.c - LPC interface for Intel ICH

Please take the opportunity to remove the filename from this header.

They have not purpose and have a habit of becoming out dated.

>   *  LPC bridge function of the Intel ICH contains many other
>   *  functional units, such as Interrupt controllers, Timers,

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog