linux-kernel - Re: [PATCH v8 5/6] mfd: lpc_ich: Add Device IDs for Intel Apollo Lake PCH

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20161026130631.GE12618@dell>
Date:   Wed, 26 Oct 2016 14:06:31 +0100
From:   Lee Jones <lee.jones@...aro.org>
To:     Tan Jui Nee <jui.nee.tan@...el.com>
Cc:     mika.westerberg@...ux.intel.com, heikki.krogerus@...ux.intel.com,
        andriy.shevchenko@...ux.intel.com, tglx@...utronix.de,
        mingo@...hat.com, hpa@...or.com, x86@...nel.org,
        ptyser@...-inc.com, linus.walleij@...aro.org,
        linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org,
        jonathan.yong@...el.com, ong.hock.yu@...el.com,
        tony.luck@...el.com, wan.ahmad.zainie.wan.mohamad@...el.com
Subject: Re: [PATCH v8 5/6] mfd: lpc_ich: Add Device IDs for Intel Apollo
 Lake PCH

On Wed, 26 Oct 2016, Lee Jones wrote:

> On Wed, 12 Oct 2016, Tan Jui Nee wrote:
> 
> > Adding Intel codename Apollo Lake platform device IDs for PCH.
> > 
> > Signed-off-by: Tan Jui Nee <jui.nee.tan@...el.com>
> > ---
> > Changes in V8:
> > 	- No change
> > 
> >  drivers/mfd/lpc_ich_core.c  | 6 ++++++
> >  include/linux/mfd/lpc_ich.h | 1 +
> >  2 files changed, 7 insertions(+)
> 
> For my own reference:
>   Acked-for-MFD-by: Lee Jones <lee.jones@...aro.org>

I should really be clear.

Please add my Ack when resubmitting this patch-set.

> > diff --git a/drivers/mfd/lpc_ich_core.c b/drivers/mfd/lpc_ich_core.c
> > index bfba832..27e7e63 100644
> > --- a/drivers/mfd/lpc_ich_core.c
> > +++ b/drivers/mfd/lpc_ich_core.c
> > @@ -56,6 +56,7 @@
> >   *	document number TBD : Wildcat Point-LP
> >   *	document number TBD : 9 Series
> >   *	document number TBD : Lewisburg
> > + *	document number TBD : Apollo Lake
> >   */
> >  
> >  #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
> > @@ -460,6 +461,10 @@ struct lpc_ich_priv {
> >  		.name = "9 Series",
> >  		.iTCO_version = 2,
> >  	},
> > +	[LPC_APL]  = {
> > +		.name = "Apollo Lake SoC",
> > +		.iTCO_version = 5,
> > +	},
> >  };
> >  
> >  /*
> > @@ -608,6 +613,7 @@ struct lpc_ich_priv {
> >  	{ PCI_VDEVICE(INTEL, 0x3b14), LPC_3420},
> >  	{ PCI_VDEVICE(INTEL, 0x3b16), LPC_3450},
> >  	{ PCI_VDEVICE(INTEL, 0x5031), LPC_EP80579},
> > +	{ PCI_VDEVICE(INTEL, 0x5ae8), LPC_APL},
> >  	{ PCI_VDEVICE(INTEL, 0x8c40), LPC_LPT},
> >  	{ PCI_VDEVICE(INTEL, 0x8c41), LPC_LPT},
> >  	{ PCI_VDEVICE(INTEL, 0x8c42), LPC_LPT},
> > diff --git a/include/linux/mfd/lpc_ich.h b/include/linux/mfd/lpc_ich.h
> > index 42307ee..397008c 100644
> > --- a/include/linux/mfd/lpc_ich.h
> > +++ b/include/linux/mfd/lpc_ich.h
> > @@ -112,6 +112,7 @@ enum lpc_chipsets {
> >  	LPC_BRASWELL,	/* Braswell SoC */
> >  	LPC_LEWISBURG,	/* Lewisburg */
> >  	LPC_9S,		/* 9 Series */
> > +	LPC_APL,	/* Apollo Lake SoC */
> >  };
> >  
> >  #endif
> 

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog