linux-kernel - Re: [PATCH] mfd: tps65217: Drop call to irq_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20161026123516.GC11267@dell>
Date:   Wed, 26 Oct 2016 13:35:16 +0100
From:   Lee Jones <lee.jones@...aro.org>
To:     Guenter Roeck <linux@...ck-us.net>
Cc:     Tony Lindgren <tony@...mide.com>, linux-omap@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Marcin Niestroj <m.niestroj@...nn-global.com>,
        Arnd Bergmann <arnd@...db.de>,
        Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [PATCH] mfd: tps65217: Drop call to irq_set_parent()

On Fri, 14 Oct 2016, Guenter Roeck wrote:

> The call to irq_set_parent() causes the following build error if tps65217
> is built as module.
> 
> ERROR: ".irq_set_parent" [drivers/mfd/tps65217.ko] undefined!
> 
> The problem was introduced with commit 6556bdacf646f ("mfd: tps65217: Add
> support for IRQs").
> 
> The author states: "I have added irq_set_parent() similarly as in
> drivers/base/regmap/regmap-irq.c. But to be honest I am not sure what it
> really does in case of tps65217."
> 
> So let's drop it.
> 
> Fixes: 6556bdacf646f ("mfd: tps65217: Add support for IRQs")
> Cc: Marcin Niestroj <m.niestroj@...nn-global.com>
> Cc: Arnd Bergmann <arnd@...db.de>
> Cc: Thomas Gleixner <tglx@...utronix.de>
> Signed-off-by: Guenter Roeck <linux@...ck-us.net>
> ---
>  drivers/mfd/tps65217.c | 1 -
>  1 file changed, 1 deletion(-)

This has been fixed now.

3118dac501bc ("kernel/irq: Export irq_set_parent()")

> diff --git a/drivers/mfd/tps65217.c b/drivers/mfd/tps65217.c
> index 9a4d8684dd32..2a57b444859c 100644
> --- a/drivers/mfd/tps65217.c
> +++ b/drivers/mfd/tps65217.c
> @@ -170,7 +170,6 @@ static int tps65217_irq_map(struct irq_domain *h, unsigned int virq,
>  	irq_set_chip_data(virq, tps);
>  	irq_set_chip_and_handler(virq, &tps65217_irq_chip, handle_edge_irq);
>  	irq_set_nested_thread(virq, 1);
> -	irq_set_parent(virq, tps->irq);
>  	irq_set_noprobe(virq);
>  
>  	return 0;

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog