linux-kernel - Re: [PATCH] led: pca9532: Use default trigger value from platform data

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-id: <d0151f25-8156-b09c-4e44-b9f7e5a911f7@samsung.com>
Date:   Wed, 26 Oct 2016 16:45:14 +0200
From:   Jacek Anaszewski <j.anaszewski@...sung.com>
To:     Felix Brack <fb@...c.ch>, riku.voipio@....fi,
        linux-leds@...r.kernel.org
Cc:     "rpurdie@...ys.net" <rpurdie@...ys.net>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] led: pca9532: Use default trigger value from platform data

Hi Felix,

Thanks for the patch. Applied.

On 10/26/2016 04:08 PM, Felix Brack wrote:
> The value for a led's default_trigger should come from platform data
> instead of data (which is always 0).
>
> Signed-off-by: Felix Brack <fb@...c.ch>
> ---
>
> diff --git a/drivers/leds/leds-pca9532.c b/drivers/leds/leds-pca9532.c
> index 09a7cffb..06e6310 100644
> --- a/drivers/leds/leds-pca9532.c
> +++ b/drivers/leds/leds-pca9532.c
> @@ -369,7 +369,7 @@ static int pca9532_configure(struct i2c_client *client,
>  			led->state = pled->state;
>  			led->name = pled->name;
>  			led->ldev.name = led->name;
> -			led->ldev.default_trigger = led->default_trigger;
> +			led->ldev.default_trigger = pled->default_trigger;
>  			led->ldev.brightness = LED_OFF;
>  			led->ldev.brightness_set_blocking =
>  						pca9532_set_brightness;
>
>
>


-- 
Best regards,
Jacek Anaszewski