linux-kernel - Re: [PATCH 1/2] kernel/smp: Make the SMP boot message common on all arches

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87d1iny8p9.fsf@concordia.ellerman.id.au>
Date:   Wed, 26 Oct 2016 16:34:42 +1100
From:   Michael Ellerman <mpe@...erman.id.au>
To:     Ingo Molnar <mingo@...nel.org>
Cc:     akpm@...l.org, tglx@...utronix.de, mingo@...hat.com, hpa@...or.com,
        x86@...nel.org, peterz@...radead.org, jgross@...e.com,
        mgorman@...hsingularity.net, richard@....at, len.brown@...el.com,
        bp@...e.de, boris.ostrovsky@...cle.com, tim.c.chen@...ux.intel.com,
        ak@...ux.intel.com, jolsa@...hat.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] kernel/smp: Make the SMP boot message common on all arches

Ingo Molnar <mingo@...nel.org> writes:
> * Michael Ellerman <mpe@...erman.id.au> wrote:
>> @@ -564,8 +560,11 @@ void __init smp_init(void)
>>  			cpu_up(cpu);
>>  	}
>>  
>> +	num_nodes = num_online_nodes();
>> +	pr_info("smp: Brought up %d node%s, %d CPUs\n",
>> +		num_nodes, (num_nodes > 1 ? "s" : ""), num_online_cpus());
>
> No objections - but pedantry requires me to mention that while we are evolving 
> this code and changing the strings I think we should make the CPU announcement 
> CPU%s smart as well: an SMP kernel on a single CPU bootup will result in 
> num_online_cpus() == 1, right?

Yeah that makes sense. I don't often boot any single CPU systems, but I
tested with maxcpus=1 and it does look nicer:

    smp: Brought up 2 nodes, 1 CPU


Will send a v2.

cheers