linux-kernel - Re: [PATCH v3] usb: musb: remove duplicated actions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 26 Oct 2016 10:37:13 -0500
From:   Bin Liu <b-liu@...com>
To:     Kirill Esipov <yesipov@...il.com>
CC:     <linux-kernel@...r.kernel.org>, <linux-usb@...r.kernel.org>,
        <gregkh@...uxfoundation.org>, <sergei.shtylyov@...entembedded.com>
Subject: Re: [PATCH v3] usb: musb: remove duplicated actions

Hi,

On Wed, Oct 26, 2016 at 05:24:27PM +0300, Kirill Esipov wrote:
> Removing unnecessary duplicated actions that we've got while merging:
> 19915e623458 ("Merge 4.1-rc7 into usb-next")
> 
> Signed-off-by: Kirill Esipov <yesipov@...il.com>
> ---
>  drivers/usb/musb/musb_core.c | 6 ------
>  1 file changed, 6 deletions(-)
> 
> diff --git a/drivers/usb/musb/musb_core.c b/drivers/usb/musb/musb_core.c
> index 27dadc0..2b04f07 100644
> --- a/drivers/usb/musb/musb_core.c
> +++ b/drivers/usb/musb/musb_core.c
> @@ -2120,12 +2120,6 @@ musb_init_controller(struct device *dev, int nIrq, void __iomem *ctrl)
>  	if (musb->ops->ep_select)
>  		musb->io.ep_select = musb->ops->ep_select;
>  
> -	/* At least tusb6010 has its own offsets */

I prefer to keep this comment and drop the first one
"/* And override them with platform specific ops if specified. */"
as it doesn't provide any value.

> -	if (musb->ops->ep_offset)
> -		musb->io.ep_offset = musb->ops->ep_offset;
> -	if (musb->ops->ep_select)
> -		musb->io.ep_select = musb->ops->ep_select;
> -
>  	if (musb->ops->fifo_mode)
>  		fifo_mode = musb->ops->fifo_mode;
>  	else
> -- 
> 2.7.4

Thanks,
-Bin.