linux-kernel - Re: [PATCH v5 12/18] x86/intel_rdt: Add "info" files to resctrl file system

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.20.1610261931470.5013@nanos>
Date:   Wed, 26 Oct 2016 19:33:07 +0200 (CEST)
From:   Thomas Gleixner <tglx@...utronix.de>
To:     "Luck, Tony" <tony.luck@...el.com>
cc:     "Yu, Fenghua" <fenghua.yu@...el.com>,
        "Anvin, H Peter" <h.peter.anvin@...el.com>,
        Ingo Molnar <mingo@...e.hu>,
        Peter Zijlstra <peterz@...radead.org>,
        Stephane Eranian <eranian@...gle.com>,
        Borislav Petkov <bp@...e.de>,
        "Hansen, Dave" <dave.hansen@...el.com>,
        Nilay Vaish <nilayvaish@...il.com>, Shaohua Li <shli@...com>,
        David Carrillo-Cisneros <davidcc@...gle.com>,
        "Shankar, Ravi V" <ravi.v.shankar@...el.com>,
        "Prakhya, Sai Praneeth" <sai.praneeth.prakhya@...el.com>,
        Vikas Shivappa <vikas.shivappa@...ux.intel.com>,
        linux-kernel <linux-kernel@...r.kernel.org>, x86 <x86@...nel.org>
Subject: Re: [PATCH v5 12/18] x86/intel_rdt: Add "info" files to resctrl file
 system

On Wed, 26 Oct 2016, Luck, Tony wrote:
> >> +        .mode        = 0444,
> >> +        .kf_ops        = &rdtgroup_kf_single_ops,
> >> +        .seq_show    = rdt_num_closid_show,
> >> +    },
> >> +    {
> >> +        .name        = "cbm_val",
> > 
> > cbm_val? Is that a value? No, it's the valid bitmask which you can set. So
> > cmb_mask or something else which is unambiguous is what you want here.
> > 
> > This is a user space interface and we really must make it as intuitive as
> > possible.
> 
> It's a bit mask for cache resources. But this interface will also control resources that are not caches, so I'd like to avoid "cbm" in the name. Perhaps "max_val"?
> 

max_val is misleading if it's always a bit mask. 'bitmask' might not be the
worst choice then.

Thanks,

	tglx