linux-kernel - Re: [PATCH v2 1/2] staging: lustre: remove broken dead code in cfs_cpt_table_create

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2652666.mQoRF2ExRO@wuerfel>
Date:   Thu, 27 Oct 2016 15:36:04 +0200
From:   Arnd Bergmann <arnd@...db.de>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     Oleg Drokin <oleg.drokin@...el.com>,
        Patrick Farrell <paf@...y.com>, lustre-devel@...ts.lustre.org,
        Bobi Jam <bobijam@...mail.com>,
        James Simmons <uja.ornl@...oo.com>, Olaf Weber <olaf@....com>,
        James Simmons <jsimmons@...radead.org>,
        Jinshan Xiong <jinshan.xiong@...el.com>,
        "John L . Hammond" <john.hammond@...el.com>,
        Liang Zhen <liang.zhen@...el.com>,
        Andreas Dilger <andreas.dilger@...el.com>,
        Shivani Bhardwaj <shivanib134@...il.com>,
        Andriy Skulysh <Andriy_Skulysh@...atex.com>,
        devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/2] staging: lustre: remove broken dead code in cfs_cpt_table_create_pattern

On Thursday, October 27, 2016 3:12:42 PM CEST Greg Kroah-Hartman wrote:
> On Tue, Oct 25, 2016 at 11:22:30PM +0200, Arnd Bergmann wrote:
> > After a recent bugfix, we get a warning about the use of an uninitialized
> > variable:
> > 
> > drivers/staging/lustre/lnet/libcfs/linux/linux-cpu.c: In function 'cfs_cpt_table_create_pattern':
> > drivers/staging/lustre/lnet/libcfs/linux/linux-cpu.c:833:7: error: 'str' may be used uninitialized in this function [-Werror=maybe-uninitialized]
> > 
> > This part of the function used to not do anything as we would reassign
> > the 'str' pointer to something else right away, but now we pass an
> > uninitialized pointer into 'strchr', which can cause a kernel page fault
> > or worse.
> > 
> > Fixes: 239fd5d41f9b ("staging: lustre: libcfs: shortcut to create CPT from NUMA topology")
> > Signed-off-by: Arnd Bergmann <arnd@...db.de>
> > ---
> >  drivers/staging/lustre/lnet/libcfs/linux/linux-cpu.c | 7 -------
> >  1 file changed, 7 deletions(-)
> 
> Hm, I already applied the v1 versions of these, right?  What changed
> with these, they seem identical to me...

The patches you applied were fine, they just had not made it into linux-next
by Tuesday, and I thought they got lost as I had sent them as part of a longer
series and I screwed up one of the two changelogs initially (you applied the
fixed v2 patch I sent immediately afterwards).

Sorry about the confusion.

	Arnd