linux-kernel - Re: [PATCH 1/4] Input: goodix - Restructure cfg checksum function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1477564370.2458.8.camel@hadess.net>
Date:   Thu, 27 Oct 2016 12:32:50 +0200
From:   Bastien Nocera <hadess@...ess.net>
To:     Franklin S Cooper Jr <fcooper@...com>, dmitry.torokhov@...il.com,
        robh+dt@...nel.org, octavian.purdila@...el.com,
        irina.tirdea@...el.com, merker@...ian.org,
        linux-input@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, nsekhar@...com, nm@...com
Subject: Re: [PATCH 1/4] Input: goodix - Restructure cfg checksum function

On Thu, 2016-10-20 at 14:59 -0500, Franklin S Cooper Jr wrote:
> Split generation of checksum into is own function. Currently it is used

"its own".

> only to determine if the checksum for the user provided configuration file
> is valid or not. However, support to dynamically alter the configuration
> file will be supported and needs a way to calculate the updated file's
> checksum. Therefore, by splitting calculating checksum into its own
> function the code can be reused.
> 

After the fixup above:

Reviewed-by: Bastien Nocera <hadess@...ess.net>