lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <1477577019.5295.30.camel@linux.intel.com>
Date:   Thu, 27 Oct 2016 17:03:39 +0300
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     vadimp@...lanox.com, dvhart@...radead.org, fengguang.wu@...el.com
Cc:     davem@...emloft.net, geert@...ux-m68k.org,
        akpm@...ux-foundation.org, kvalo@...eaurora.org,
        gregkh@...uxfoundation.org, mchehab@...nel.org, linux@...ck-us.net,
        linux-kernel@...r.kernel.org, platform-driver-x86@...r.kernel.org,
        jiri@...nulli.us
Subject: Re: [patch v1 2/2] drivers/platform/x86: add mlxcpld-hotplug driver
 registration to mlx-platform driver

On Thu, 2016-10-27 at 13:59 +0000, vadimp@...lanox.com wrote:
> From: Vadim Pasternak <vadimp@...lanox.com>

Care to fix that ^^^ ? (Hint: it shouldn't be there if author and
submitter is the same guy)


> Add calls for mlxcpld-hotplug platform driver
> registration/unregistration
> and add platform hotplug data configurations.

Would you provide more information what is done, where it is described
in the specs and how user can utilize the change?

> --- a/drivers/platform/x86/mlx-platform.c
> +++ b/drivers/platform/x86/mlx-platform.c
> @@ -37,8 +37,9 @@
>  #include <linux/i2c.h>
>  #include <linux/i2c-mux.h>
>  #include <linux/module.h>

> -#include <linux/platform_device.h>

This...

>  #include <linux/platform_data/i2c-mux-reg.h>
> +#include <linux/platform_data/mlxcpld-hotplug.h>


> +#include <linux/platform_device.h>

...and this doesn't belong to the patch.


-- 
Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Intel Finland Oy

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ