[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <1477575883.2458.24.camel@hadess.net>
Date: Thu, 27 Oct 2016 15:44:43 +0200
From: Bastien Nocera <hadess@...ess.net>
To: Irina Tirdea <irina.tirdea@...el.com>, linux-input@...r.kernel.org
Cc: Dmitry Torokhov <dmitry.torokhov@...il.com>,
Aleksei Mamlin <mamlinav@...il.com>,
Karsten Merker <merker@...ian.org>,
Mark Rutland <mark.rutland@....com>,
Rob Herring <robh+dt@...nel.org>,
Octavian Purdila <octavian.purdila@...el.com>,
linux-kernel@...r.kernel.org, devicetree@...r.kernel.org
Subject: Re: [PATCH v12 5/5] Input: goodix - add support for gt9157
On Sat, 2016-09-10 at 20:57 +0300, Irina Tirdea wrote:
> Goodix touchscreen GT9157 has the same basic functionality
> as GT911 touchscreen. This is based on Goodix datasheets
> for GT911 and GT9157 and on Goodix driver gt9xx.c for
> Android (publicly available in Android kernel trees for
> various devices).
>
> Signed-off-by: Irina Tirdea <irina.tirdea@...el.com>
Looks obviously correct.
Reviewed-by: Bastien Nocera <hadess@...ess.net>
> ---
> Documentation/devicetree/bindings/input/touchscreen/goodix.txt | 1 +
> drivers/input/touchscreen/goodix.c | 2
> ++
> 2 files changed, 3 insertions(+)
>
> diff --git
> a/Documentation/devicetree/bindings/input/touchscreen/goodix.txt
> b/Documentation/devicetree/bindings/input/touchscreen/goodix.txt
> index ef5f42d..421b7d5 100644
> --- a/Documentation/devicetree/bindings/input/touchscreen/goodix.txt
> +++ b/Documentation/devicetree/bindings/input/touchscreen/goodix.txt
> @@ -5,6 +5,7 @@ Required properties:
> - compatible : Should be "goodix,gt911"
> or "goodix,gt9110"
> or "goodix,gt912"
> + or "goodix,gt9157"
> or "goodix,gt927"
> or "goodix,gt9271"
> or "goodix,gt928"
> diff --git a/drivers/input/touchscreen/goodix.c
> b/drivers/input/touchscreen/goodix.c
> index 6fba804..bd4dd4b 100644
> --- a/drivers/input/touchscreen/goodix.c
> +++ b/drivers/input/touchscreen/goodix.c
> @@ -192,6 +192,7 @@ static int goodix_get_cfg_len(u16 id)
> case 911:
> case 9271:
> case 9110:
> + case 9157:
> case 927:
> case 928:
> return GOODIX_CONFIG_911_LENGTH;
> @@ -1168,6 +1169,7 @@ static const struct of_device_id
> goodix_of_match[] = {
> { .compatible = "goodix,gt911" },
> { .compatible = "goodix,gt9110" },
> { .compatible = "goodix,gt912" },
> + { .compatible = "goodix,gt9157" },
> { .compatible = "goodix,gt927" },
> { .compatible = "goodix,gt9271" },
> { .compatible = "goodix,gt928" },
Powered by blists - more mailing lists