linux-kernel - Re: [RFC v1 05/14] bus1: util

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20161027150039.GK3157@twins.programming.kicks-ass.net>
Date:   Thu, 27 Oct 2016 17:00:39 +0200
From:   Peter Zijlstra <peterz@...radead.org>
To:     David Herrmann <dh.herrmann@...il.com>
Cc:     linux-kernel@...r.kernel.org,
        Andy Lutomirski <luto@...capital.net>,
        Jiri Kosina <jikos@...nel.org>, Greg KH <greg@...ah.com>,
        Hannes Reinecke <hare@...e.com>,
        Steven Rostedt <rostedt@...dmis.org>,
        Arnd Bergmann <arnd@...db.de>, Tom Gundersen <teg@...m.no>,
        Josh Triplett <josh@...htriplett.org>,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [RFC v1 05/14] bus1: util - pool utility library

On Thu, Oct 27, 2016 at 02:59:07PM +0200, Peter Zijlstra wrote:
> On Wed, Oct 26, 2016 at 09:18:01PM +0200, David Herrmann wrote:
> > +/* insert slice into the free tree */
> > +static void bus1_pool_slice_link_free(struct bus1_pool_slice *slice,
> > +				      struct bus1_pool *pool)
> > +{
> > +	struct rb_node **n, *prev = NULL;
> > +	struct bus1_pool_slice *ps;
> > +
> > +	n = &pool->slices_free.rb_node;
> > +	while (*n) {
> > +		prev = *n;
> > +		ps = container_of(prev, struct bus1_pool_slice, rb);
> > +		if (slice->size < ps->size)
> > +			n = &prev->rb_left;
> > +		else
> > +			n = &prev->rb_right;
> > +	}
> > +
> > +	rb_link_node(&slice->rb, prev, n);
> > +	rb_insert_color(&slice->rb, &pool->slices_free);
> > +}
> 
> If you only sort free slices by size, how do you merge contiguous free
> slices?

Ah, I see, you also keep an ordered list of slices and use that one
function up from here.