linux-kernel - Re: [PATCH v2] inotify: Convert to using per-namespace limits

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87y419re0c.fsf@xmission.com>
Date:   Thu, 27 Oct 2016 10:46:27 -0500
From:   ebiederm@...ssion.com (Eric W. Biederman)
To:     Nikolay Borisov <kernel@...p.com>
Cc:     jack@...e.cz, linux-kernel@...r.kernel.org, serge@...lyn.com,
        containers@...ts.linux-foundation.org
Subject: Re: [PATCH v2] inotify: Convert to using per-namespace limits

Nikolay Borisov <kernel@...p.com> writes:

> On 10/11/2016 10:36 AM, Nikolay Borisov wrote:
>> This patchset converts inotify to using the newly introduced
>> per-userns sysctl infrastructure.
>> 
>> Currently the inotify instances/watches are being accounted in the
>> user_struct structure. This means that in setups where multiple
>> users in unprivileged containers map to the same underlying
>> real user (i.e. pointing to the same user_struct) the inotify limits
>> are going to be shared as well, allowing one user(or application) to exhaust
>> all others limits.
>> 
>> Fix this by switching the inotify sysctls to using the
>> per-namespace/per-user limits. This will allow the server admin to
>> set sensible global limits, which can further be tuned inside every
>> individual user namespace. Additionally, in order to preserve the
>> sysctl ABI make the existing inotify instances/watches sysctls
>> modify the values of the initial user namespace.
>> 
>> Signed-off-by: Nikolay Borisov <kernel@...p.com>
>> ---
>> 
>> So here is a revised version which retains the existing sysctls,
>> and hooks them to the init_user_ns values. 
>
> Gentle ping, now that rc1 has shipped and Jan's sysctl concern hopefully
> resolved.

I plan to give this a once over and merge this.  I have a very funny
pile of serious bug fixes that jumped on my at the beginning of this
development cycle and a cold so I am getting to this more slowly than I
would like.

Eric