linux-kernel - [PATCH] null_blk: Add notes to use LightNVM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <37a5a6a3-cd8b-db98-b4f3-7bd66a5bf4d8@gmail.com>
Date:   Thu, 27 Oct 2016 11:56:17 -0400
From:   Yasuaki Ishimatsu <yasu.isimatu@...il.com>
To:     linux-kernel@...r.kernel.org, linux-block@...r.kernel.org
Cc:     axboe@...nel.dk
Subject: [PATCH] null_blk: Add notes to use LightNVM

If CONFIG_NVM is disabled, loading null_block module with use_lightnvm=1
fails. But there are no messages and documents related to the failure.

So the patch adds the notes to use LightNVM.

Signed-off-by: Yasuaki Ishimatsu <isimatu.yasuaki@...fujitsu.com>
Cc: Jens Axboe <axboe@...nel.dk>
---
  Documentation/block/null_blk.txt | 2 +-
  drivers/block/null_blk.c         | 1 +
  2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/Documentation/block/null_blk.txt b/Documentation/block/null_blk.txt
index d8880ca..0365a26 100644
--- a/Documentation/block/null_blk.txt
+++ b/Documentation/block/null_blk.txt
@@ -72,4 +72,4 @@ use_per_node_hctx=[0/1]: Default: 0
       queue for each CPU node in the system.

  use_lightnvm=[0/1]: Default: 0
-  Register device with LightNVM. Requires blk-mq to be used.
+  Register device with LightNVM. Requires blk-mq and CONFIG_NVM=y to be used.
diff --git a/drivers/block/null_blk.c b/drivers/block/null_blk.c
index ba6f4a2e..4943ee2 100644
--- a/drivers/block/null_blk.c
+++ b/drivers/block/null_blk.c
@@ -577,6 +577,7 @@ static void null_nvm_unregister(struct nullb *nullb)
  #else
  static int null_nvm_register(struct nullb *nullb)
  {
+	pr_err("null_blk: CONFIG_NVM needs to be enabled for LightNVM\n");
  	return -EINVAL;
  }
  static void null_nvm_unregister(struct nullb *nullb) {}
-- 
1.8.3.1