linux-kernel - Re: [PATCH] irq-bcm2836: Prevent spurious interrupts, and trap them early

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87eg31fybc.fsf@eliezer.anholt.net>
Date:   Thu, 27 Oct 2016 11:20:55 -0700
From:   Eric Anholt <eric@...olt.net>
To:     Thomas Gleixner <tglx@...utronix.de>
Cc:     linux-rpi-kernel@...ts.infradead.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        Stephen Warren <swarren@...dotorg.org>,
        Lee Jones <lee@...nel.org>,
        bcm-kernel-feedback-list@...adcom.com,
        Jason Cooper <jason@...edaemon.net>,
        Marc Zyngier <marc.zyngier@....com>,
        Phil Elwell <phil@...pberrypi.org>
Subject: Re: [PATCH] irq-bcm2836: Prevent spurious interrupts, and trap them early

Eric Anholt <eric@...olt.net> writes:

> From: Phil Elwell <phil@...pberrypi.org>
>
> The old arch-specific IRQ macros included a dsb to ensure the
> write to clear the mailbox interrupt completed before returning
> from the interrupt. The BCM2836 irqchip driver needs the same
> precaution to avoid spurious interrupts.
>
> Spurious interrupts are still possible for other reasons,
> though, so trap them early.
>
> Signed-off-by: Phil Elwell <phil@...pberrypi.org>
> Signed-off-by: Eric Anholt <eric@...olt.net>
> ---
>
> Phil, your patch didn't apply because it looks like you pasted into
> gmail (tabs got converted to spaces).  git-send-email can avoid that.
> I've pulled it out of the rpi tree and applied the s-o-b from your
> email.
>
> Also, patches to lkml need to be sent to the relevant maintainers or
> they won't get picked up.  ./scripts/get_maintainer.pl <patch> can
> give you the list of who to send to/cc.

And then it was my turn to fumble a patch email.  Autocompleted the
wrong version(s).  Resending :(