linux-kernel - Re: [RFC PATCH] ata: piix: wait for end of asynchronous probing before

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20161027185935.GA17657@htj.duckdns.org>
Date:   Thu, 27 Oct 2016 14:59:35 -0400
From:   Tejun Heo <tj@...nel.org>
To:     Rob Herring <robh@...nel.org>
Cc:     Corentin Labbe <clabbe.montjoie@...il.com>,
        "linux-ide@...r.kernel.org" <linux-ide@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Subject: Re: [RFC PATCH] ata: piix: wait for end of asynchronous probing
 before

Hello, Rob.

On Thu, Oct 27, 2016 at 01:55:19PM -0500, Rob Herring wrote:
> Seems like this is mixing async drv probe and async scsi scan and the
> problem is in the latter? I don't think async drv probe should have
> any problems. If a driver probe starts some async operation, then it
> seems to me that it is its responsibility to wait for completion in
> remove().

I'm not sure about that.  The async operation synchronization isn't
per-driver or module.  Both during boot and module operations, they're
synchronized globally, which makes sense given its purpose and that's
also why we don't see these brekages without this debug option.  It
doesn't make sense to me to add a whole new set of behaviors just for
a debug option.

Thanks.

-- 
tejun