linux-kernel - Re: linux-next: build warning in Linus' tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 27 Oct 2016 15:48:37 -0700
From:   Linus Torvalds <torvalds@...ux-foundation.org>
To:     Stephen Rothwell <sfr@...b.auug.org.au>,
        Andrey Ryabinin <aryabinin@...tuozzo.com>,
        Alexander Potapenko <glider@...gle.com>,
        Dmitry Vyukov <dvyukov@...gle.com>
Cc:     linux-next <linux-next@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: linux-next: build warning in Linus' tree

On Thu, Oct 27, 2016 at 3:29 PM, Stephen Rothwell <sfr@...b.auug.org.au> wrote:
>
> Building your tree, today's linux-next build (powerpc ppc64_defconfig)
> produced this warning:
>
> mm/memory_hotplug.c: In function 'try_offline_node':
> mm/memory_hotplug.c:2120:6: warning: unused variable 'i' [-Wunused-variable]
>  int i;
>      ^
>
> Introduced by commit
>
>   9dcb8b685fc3 ("mm: remove per-zone hashtable of bitlock waitqueues")

Strange. I wonder why I didn't see that warning. Not with
allmodconfig, and not with my normal build.

[ Looks around ]

Hmm. Apparently "allmodconfig" doesn't actually enable memory hotplug.
And the reason is that allmodconfig enables KASAN, which then disables
MEMORY_HOTPLUG.

I wonder if we should make KASAN depend on !COMPILE_TEST, because it
does seem to disable a lot of build-time testing.

Oh well. I'll remove the stupid unused variable, thanks for the heads-up.

          Linus