linux-kernel - Re: linux-next: build warning in Linus' tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAG_fn=WCvtf7yvj7JT5ahA21+P3F0Q==fqhS4e-3B=oRuPnVrA@mail.gmail.com>
Date:   Thu, 27 Oct 2016 16:05:58 -0700
From:   Alexander Potapenko <glider@...gle.com>
To:     Linus Torvalds <torvalds@...ux-foundation.org>
Cc:     Stephen Rothwell <sfr@...b.auug.org.au>,
        Andrey Ryabinin <aryabinin@...tuozzo.com>,
        Dmitry Vyukov <dvyukov@...gle.com>,
        linux-next <linux-next@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: linux-next: build warning in Linus' tree

On Thu, Oct 27, 2016 at 4:01 PM, Linus Torvalds
<torvalds@...ux-foundation.org> wrote:
> On Thu, Oct 27, 2016 at 3:48 PM, Linus Torvalds
> <torvalds@...ux-foundation.org> wrote:
>>
>> I wonder if we should make KASAN depend on !COMPILE_TEST, because it
>> does seem to disable a lot of build-time testing.
>
> Actually, we should probably just make the MEMORY_HOTPLUG dependency be
>
>         depends on COMPILE_TEST || !KASAN

Maybe we could just reverse the MEMORY_HOTPLUG->!KASAN dependency to
make it KASAN->!MEMORY_HOTPLUG?

Is it at all correct that allmodconfig enables KASAN? If/when we have
other compiler-based tools, which of them will allmodconfig pick?
> since the memory-hotplug code should still *build* with KASAN, it just
> doesn't work. That's exactly what the COMPILE_TEST config option is
> there for - to get build coverage even for things that aren't
> necessarily sane to run.
>
> I'll do that, to get my build coverage up. I really expected my
> allmodconfig builds to verify that I had removed the per-zone
> waitqueue code completely, and I'm happy that the breakage was
> apparently limited to that unused variable..
>
> In the meantime, thanks for noticing and letting me know.
>
>             Linus



-- 
Alexander Potapenko
Software Engineer

Google Germany GmbH
Erika-Mann-Straße, 33
80636 München

Geschäftsführer: Matthew Scott Sucherman, Paul Terence Manicle
Registergericht und -nummer: Hamburg, HRB 86891
Sitz der Gesellschaft: Hamburg