linux-kernel - Re: [RFC PATCH 0/3] sched: Introduce Window Assisted Load Tracking

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20161028092308.GZ3102@twins.programming.kicks-ass.net>
Date:   Fri, 28 Oct 2016 11:23:08 +0200
From:   Peter Zijlstra <peterz@...radead.org>
To:     Vikram Mulukutla <markivx@...eaurora.org>
Cc:     linux-kernel@...r.kernel.org, Ingo Molnar <mingo@...nel.org>,
        Srivatsa Vaddagiri <vatsa@...eaurora.org>,
        Steve Muckle <steve.muckle@...aro.org>,
        Olav Haugan <ohaugan@...eaurora.org>,
        Syed Rameez Mustafa <rameezmustafa@...eaurora.org>,
        Joonwoo Park <joonwoop@...eaurora.org>,
        Pavankumar Kondeti <pkondeti@...eaurora.org>,
        Saravana Kannan <skannan@...eaurora.org>,
        Bryan Huntsman <bryanh@...eaurora.org>,
        Juri Lelli <juri.lelli@....com>,
        Morten Rasmussen <morten.rasmussen@....com>,
        Dietmar Eggemann <dietmar.eggemann@....com>,
        Chris Redpath <chris.redpath@....com>,
        Robin Randhawa <robin.randhawa@....com>,
        Patrick Bellasi <patrick.bellasi@....com>,
        Todd Kjos <tkjos@...gle.com>,
        Srinath Sridharan <srinathsr@...gle.com>,
        Andres Oportus <andresoportus@...gle.com>,
        Leo Yan <leo.yan@...aro.org>,
        Vincent Guittot <vincent.guittot@...aro.org>,
        Vikram Mulukutla <markivx@...eauorora.org>
Subject: Re: [RFC PATCH 0/3] sched: Introduce Window Assisted Load Tracking

On Fri, Oct 28, 2016 at 12:55:52AM -0700, Vikram Mulukutla wrote:
> On 2016-10-28 00:29, Peter Zijlstra wrote:
> >On Fri, Oct 28, 2016 at 12:10:39AM -0700, Vikram Mulukutla wrote:
> >>
> >>We propose Window-Assisted Load Tracking (WALT) as an alternative or
> >>additional load tracking scheme in lieu of or along with PELT, one
> >>that in our estimation better tracks task demand and CPU utilization
> >>especially for use cases on mobile devices. WALT was conceived by
> >>Srivatsa Vaddagiri to provide better perf-per-watt numbers on
> >>asymmetric CPU (frequency and/or IPC) implementations, (specifically
> >>on Qualcomm Snapgdragon chipsets running Android) and its metrics
> >>have been used to guide task placement and p-state selection (load
> >>balancing in CFS still uses PELT statistics). WALT is now present in
> >>the android-common kernel as well.
> >
> >And how come we only learn of it after its already shipping? Isn't that
> >arse backwards?
> 
> Yes, but also we were not confident that it would be close to being
> acceptable
> upstream since it was intricately tied to our HMP scheduler. However now
> that
> more parties including the folks at ARM are interested, and given that EAS
> exists and schedutil was merged into mainline, we felt it the right time
> to try and introduce the concept. In general we are seriously trying to get
> more things upstream and converge.

That's good to hear, great!

That said, I would much prefer to modify/augment existing PELT stuff
than to add an entirely new set of accounting on the side of it. But
yes, I (and others) are aware of the pain points you mentioned with
using the PELT signal for schedutil.

We'll have to see what we can come up with.