[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20161028101919.GA25564@leoy-linaro>
Date: Fri, 28 Oct 2016 18:19:19 +0800
From: Leo Yan <leo.yan@...aro.org>
To: Jaehoon Chung <jh80.chung@...sung.com>
Cc: Vincent Guittot <vincent.guittot@...aro.org>,
John Stultz <john.stultz@...aro.org>,
Guodong Xu <guodong.xu@...aro.org>,
Wei Xu <xuwei5@...ilicon.com>,
Rob Herring <robh+dt@...nel.org>,
Rob Herring <rob.herring@...aro.org>,
Mark Rutland <mark.rutland@....com>,
Catalin Marinas <catalin.marinas@....com>,
Will Deacon <will.deacon@....com>,
"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
Xinliang Liu <xinliang.liu@...aro.org>,
linux-kernel <linux-kernel@...r.kernel.org>,
Fathi Boudra <fathi.boudra@...aro.org>,
LAK <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH v2 2/2] arm64: dts: hi6220: add resets property into
dwmmc nodes
On Fri, Oct 28, 2016 at 06:54:58PM +0900, Jaehoon Chung wrote:
[...]
> >>> Could you share the log? Is there any log about failure?
> >>
> >> Sure, please see below log:
> >
> > It's related with -EPROBE_DEFER..I'm not sure but if CONFIG_RESET_CONTROLLER is enabled, it's searching for reset controller.
> > Maybe hi6220 has handled the reset controller(?)...
> >
> > I'm checking devm_reset_control_xxx...It's possible to occur the other boards which enabled RESET_CONTROLLER..
>
> Could you check the below thing..
>
> /* find reset controller when exist */
> - pdata->rstc = devm_reset_control_get_optional(dev, NULL);
> + pdata->rstc = devm_reset_control_get_optional(dev, "dwmci-reset");
> if (IS_ERR(pdata->rstc)) {
> if (PTR_ERR(pdata->rstc) == -EPROBE_DEFER)
> return ERR_PTR(-EPROBE_DEFER);
Confirmed with this fixing, the kernel can bootup successfully.
Thanks for this.
> To prevent the wrong controlling, how about adding "#reset-names" for dwmmc controller?
>
>
> Best Regards,
> Jaehoon Chung
Powered by blists - more mailing lists