linux-kernel - Re: [RFC v1 09/14] bus1: provide transaction context for multicasts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20161028143726.GJ3175@twins.programming.kicks-ass.net>
Date:   Fri, 28 Oct 2016 16:37:26 +0200
From:   Peter Zijlstra <peterz@...radead.org>
To:     David Herrmann <dh.herrmann@...il.com>
Cc:     linux-kernel@...r.kernel.org,
        Andy Lutomirski <luto@...capital.net>,
        Jiri Kosina <jikos@...nel.org>, Greg KH <greg@...ah.com>,
        Hannes Reinecke <hare@...e.com>,
        Steven Rostedt <rostedt@...dmis.org>,
        Arnd Bergmann <arnd@...db.de>, Tom Gundersen <teg@...m.no>,
        Josh Triplett <josh@...htriplett.org>,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [RFC v1 09/14] bus1: provide transaction context for multicasts

On Wed, Oct 26, 2016 at 09:18:05PM +0200, David Herrmann wrote:
> From: Tom Gundersen <teg@...m.no>
> 
> The transaction engine is an object that lives on the stack and is used
> to stage and commit multicasts properly. Unlike unicasts, a multicast
> cannot just be queued on each destination, but must be properly
> synchronized. This requires us to first stage each message on their
> respective destination, then sync and tick the clocks, and eventual
> commit all messages.
> 
> The transaction context implements this logic for both, unicasts and
> multicasts. It hides the timestamp handling and takes care to properly
> synchronize accesses to the peer queues.
> 
> Signed-off-by: Tom Gundersen <teg@...m.no>
> Signed-off-by: David Herrmann <dh.herrmann@...il.com>
> ---
>  ipc/bus1/Makefile |   1 +
>  ipc/bus1/peer.c   |   2 +
>  ipc/bus1/peer.h   |   3 +
>  ipc/bus1/tx.c     | 360 ++++++++++++++++++++++++++++++++++++++++++++++++++++++
>  ipc/bus1/tx.h     | 102 ++++++++++++++++

See, this is way more than 4 lines.

You don't need any of this for causality.