linux-kernel - Re: [RFC 12/14] regmap: SoundWire: Add regmap support for SoundWire bus

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20161028180355.o7byx4llwurfpnut@sirena.org.uk>
Date:   Fri, 28 Oct 2016 19:03:55 +0100
From:   Mark Brown <broonie@...nel.org>
To:     Hardik Shah <hardik.t.shah@...el.com>
Cc:     alsa-devel@...a-project.org, linux-kernel@...r.kernel.org,
        tiwai@...e.de, pierre-louis.bossart@...ux.intel.com,
        lgirdwood@...il.com, plai@...eaurora.org, patches.audio@...el.com,
        Sanyog Kale <sanyog.r.kale@...el.com>
Subject: Re: [RFC 12/14] regmap: SoundWire: Add regmap support for SoundWire
 bus

On Fri, Oct 21, 2016 at 06:11:10PM +0530, Hardik Shah wrote:

> +static inline void get_t_size(size_t *t_val_size, size_t *t_size,
> +						int *reg_addr,
> +						int *offset,
> +						size_t *val_size)
> +{
> +
> +		*t_val_size += *t_size;
> +		*offset += *t_size;

So, I started by taking a look at this patch to get a sense of what the
API would look like and I see that we're not following CodingStyle with
everything indented twice :(

> +static int regmap_sdw_gather_write(void *context,
> +			   const void *reg, size_t reg_size,
> +			   const void *val, size_t val_size)
> +{

> +	if (!sdw)
> +		return 0;

Silently ignoring errors :(

> +	if (val_size > SDW_MAX_REG_ADDR)
> +		t_size = SDW_MAX_REG_ADDR - reg_command;
> +	else
> +		t_size = val_size;

This needs at least some kind of comment?

Download attachment "signature.asc" of type "application/pgp-signature" (456 bytes)