linux-kernel - Re: [PATCH] Revert "usb: dwc2: gadget: fix TX FIFO size and address initialization"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d6b4322d-1c2b-2036-79cf-cf5aaa14f2e1@synopsys.com>
Date:   Fri, 28 Oct 2016 11:22:48 -0700
From:   John Youn <John.Youn@...opsys.com>
To:     Leo Yan <leo.yan@...aro.org>, John Youn <John.Youn@...opsys.com>,
        "Greg Kroah-Hartman" <gregkh@...uxfoundation.org>,
        "linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        John Stultz <john.stultz@...aro.org>,
        "Guodong Xu" <guodong.xu@...aro.org>,
        "zhangfei.gao@...aro.org" <zhangfei.gao@...aro.org>,
        Vincent Guittot <vincent.guittot@...aro.org>,
        Steve Muckle <steve.muckle@...aro.org>,
        Dietmar Eggemann <dietmar.eggemann@....com>,
        Robert Baldyga <r.baldyga@...sung.com>
Subject: Re: [PATCH] Revert "usb: dwc2: gadget: fix TX FIFO size and address
 initialization"

On 10/28/2016 8:52 AM, Leo Yan wrote:
> This reverts commit aa381a7259c3f53727bcaa8c5f9359e940a0e3fd.
> 
> Reverting this patch, as it incorrectly assumes TX FIFO size is fixed
> and cannot change FIFO size; it removes all related dt binding code
> and have no chance to set FIFO size at init phase.
> 
> As result, Hi6220 cannot set correct FIFO size for gadget driver and
> ethernet on USB function driver is easily to hang. And in the kernel
> there also have other platforms set FIFO size for usb controller,
> e.g. arch/arm64/boot/dts/rockchip/rk3368.dtsi.
> 
> This patch re-enables dt binding to set FIFO size.
> 
> Signed-off-by: Leo Yan <leo.yan@...aro.org>


This is already queued for 4.9-rc in Felipe's tree.

Hi Felipe,

It seems like your fixes branch for 4.9-rc2 didn't get merged
upstream. Can we get them pulled for the next -rc? There are platforms
that are broken on 4.9 without them.

Thanks,
John