[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <CALAqxLX9_y8CpagsUeorOE4gpR6_i-_G+EZfXNpBxare3VnJCg@mail.gmail.com>
Date: Fri, 28 Oct 2016 14:12:56 -0700
From: John Stultz <john.stultz@...aro.org>
To: Leo Yan <leo.yan@...aro.org>
Cc: Jaehoon Chung <jh80.chung@...sung.com>,
Vincent Guittot <vincent.guittot@...aro.org>,
Guodong Xu <guodong.xu@...aro.org>,
Wei Xu <xuwei5@...ilicon.com>,
Rob Herring <robh+dt@...nel.org>,
Rob Herring <rob.herring@...aro.org>,
Mark Rutland <mark.rutland@....com>,
Catalin Marinas <catalin.marinas@....com>,
Will Deacon <will.deacon@....com>,
"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
Xinliang Liu <xinliang.liu@...aro.org>,
linux-kernel <linux-kernel@...r.kernel.org>,
Fathi Boudra <fathi.boudra@...aro.org>,
LAK <linux-arm-kernel@...ts.infradead.org>,
Ulf Hansson <ulf.hansson@...aro.org>
Subject: Re: [PATCH v2 2/2] arm64: dts: hi6220: add resets property into dwmmc nodes
On Fri, Oct 28, 2016 at 5:34 AM, Leo Yan <leo.yan@...aro.org> wrote:
> On Fri, Oct 28, 2016 at 08:52:49PM +0900, Jaehoon Chung wrote:
>
> [...]
>
>> >> Could you check the below thing..
>> >>
>> >> /* find reset controller when exist */
>> >> - pdata->rstc = devm_reset_control_get_optional(dev, NULL);
>> >> + pdata->rstc = devm_reset_control_get_optional(dev, "dwmci-reset");
>> >> if (IS_ERR(pdata->rstc)) {
>> >> if (PTR_ERR(pdata->rstc) == -EPROBE_DEFER)
>> >> return ERR_PTR(-EPROBE_DEFER);
>> >
>> > Confirmed with this fixing, the kernel can bootup successfully.
>> >
>> > Thanks for this.
>>
>> Thanks for checking this..If this approach is not bad, i will send the patch.
>> Or if there are other good approaches, let me know, plz.
>
> I'd like Guodong and John to confirm for Hikey specific. I have no
> knowledge for this so cannot answer.
No objection from me. I hadn't run into the issue, as I'm not booting
off the sd card.
The patch from Jaehoon doesn't seem to cause trouble in my testing so
far, so I think its worth generating a patch and sending it in for
4.9-rc
thanks
-john
Powered by blists - more mailing lists