linux-kernel - Re: [RFC 1/3] regulator: core: Add over current changed event

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20161029184031.adjybckguxzfu3pq@sirena.org.uk>
Date:   Sat, 29 Oct 2016 12:40:31 -0600
From:   Mark Brown <broonie@...nel.org>
To:     Axel Haslam <ahaslam@...libre.com>
Cc:     Liam Girdwood <lgirdwood@...il.com>,
        Kevin Hilman <khilman@...libre.com>,
        Sekhar Nori <nsekhar@...com>,
        David Lechner <david@...hnology.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [RFC 1/3] regulator: core: Add over current changed event

On Fri, Oct 28, 2016 at 09:41:44PM +0200, Axel Haslam wrote:

> i think today each time an event occurs a notification is sent with the
> corresponding flag(s) set.

Right, so I think the problem here is actually that you called this 
REGULATOR_EVENT_OVER_CURRENT_CHANGE with the _CHANGE on the end which
means it's just saying that the user has to go poll to see if the device
is or is not over current separately at which point you may as well pull
in all the other error things into what you're polling for.  If you'd
dropped the _CHANGE it'd be consistent with the other events we have for
errors and fine.

Download attachment "signature.asc" of type "application/pgp-signature" (456 bytes)